2021-03-13 02:52:01

by Tom Saeger

Subject: [PATCH] cpufreq: cppc: simplify default delay_us setting

Simplify case when setting default in cppc_cpufreq_get_transition_delay_us.

Signed-off-by: Tom Saeger <[email protected]>
---
drivers/cpufreq/cppc_cpufreq.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 8a482c434ea6..2f769b1630c5 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -216,26 +216,16 @@ static unsigned int cppc_cpufreq_get_transition_delay_us(unsigned int cpu)
{
unsigned long implementor = read_cpuid_implementor();
unsigned long part_num = read_cpuid_part_number();
- unsigned int delay_us = 0;

switch (implementor) {
case ARM_CPU_IMP_QCOM:
switch (part_num) {
case QCOM_CPU_PART_FALKOR_V1:
case QCOM_CPU_PART_FALKOR:
- delay_us = 10000;
- break;
- default:
- delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
- break;
+ return 10000;
}
- break;
- default:
- delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
- break;
}
-
- return delay_us;
+ return cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
}

#else
--
2.30.1

2021-03-15 05:03:22

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: cppc: simplify default delay_us setting

On 12-03-21, 19:50, Tom Saeger wrote:
> Simplify case when setting default in cppc_cpufreq_get_transition_delay_us.
>
> Signed-off-by: Tom Saeger <[email protected]>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 8a482c434ea6..2f769b1630c5 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -216,26 +216,16 @@ static unsigned int cppc_cpufreq_get_transition_delay_us(unsigned int cpu)
> {
> unsigned long implementor = read_cpuid_implementor();
> unsigned long part_num = read_cpuid_part_number();
> - unsigned int delay_us = 0;
>
> switch (implementor) {
> case ARM_CPU_IMP_QCOM:
> switch (part_num) {
> case QCOM_CPU_PART_FALKOR_V1:
> case QCOM_CPU_PART_FALKOR:
> - delay_us = 10000;
> - break;
> - default:
> - delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
> - break;
> + return 10000;
> }
> - break;
> - default:
> - delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
> - break;
> }
> -
> - return delay_us;
> + return cppc_get_transition_latency(cpu) / NSEC_PER_USEC;
> }

Applied. Thanks.

--
viresh