2020-10-26 13:24:39

by Vincenzo Frascino

Subject: [PATCH 5/6] kselftest/arm64: Fix check_ksm_options test

The check_ksm_options test reports the error below because the test
plan is not declared correctly:

# Planned tests != run tests (0 != 4)

Fix the test adding the correct test plan declaration.

Fixes: f981d8fa2646 ("kselftest/arm64: Verify KSM page merge for MTE pages")
Cc: Shuah Khan <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Gabor Kertesz <[email protected]>
Cc: Amit Daniel Kachhap <[email protected]>
Signed-off-by: Vincenzo Frascino <[email protected]>
---
tools/testing/selftests/arm64/mte/check_ksm_options.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/arm64/mte/check_ksm_options.c b/tools/testing/selftests/arm64/mte/check_ksm_options.c
index bc41ae630c86..3b23c4d61d38 100644
--- a/tools/testing/selftests/arm64/mte/check_ksm_options.c
+++ b/tools/testing/selftests/arm64/mte/check_ksm_options.c
@@ -140,6 +140,10 @@ int main(int argc, char *argv[])
/* Register signal handlers */
mte_register_signal(SIGBUS, mte_default_handler);
mte_register_signal(SIGSEGV, mte_default_handler);
+
+ /* Set test plan */
+ ksft_set_plan(4);
+
/* Enable KSM */
mte_ksm_setup();

--
2.28.0

2020-10-28 06:52:29

by Amit Kachhap

Subject: Re: [PATCH 5/6] kselftest/arm64: Fix check_ksm_options test

On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_ksm_options test reports the error below because the test
> plan is not declared correctly:
>
> # Planned tests != run tests (0 != 4)
>
> Fix the test adding the correct test plan declaration.
This change makes sense and got missed earlier.
Acked by: Amit Daniel Kachhap <[email protected]>

>
> Fixes: f981d8fa2646 ("kselftest/arm64: Verify KSM page merge for MTE pages")
> Cc: Shuah Khan <[email protected]>
> Cc: Catalin Marinas <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Gabor Kertesz <[email protected]>
> Cc: Amit Daniel Kachhap <[email protected]>
> Signed-off-by: Vincenzo Frascino <[email protected]>
> ---
> tools/testing/selftests/arm64/mte/check_ksm_options.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/arm64/mte/check_ksm_options.c b/tools/testing/selftests/arm64/mte/check_ksm_options.c
> index bc41ae630c86..3b23c4d61d38 100644
> --- a/tools/testing/selftests/arm64/mte/check_ksm_options.c
> +++ b/tools/testing/selftests/arm64/mte/check_ksm_options.c
> @@ -140,6 +140,10 @@ int main(int argc, char *argv[])
> /* Register signal handlers */
> mte_register_signal(SIGBUS, mte_default_handler);
> mte_register_signal(SIGSEGV, mte_default_handler);
> +
> + /* Set test plan */
> + ksft_set_plan(4);
> +
> /* Enable KSM */
> mte_ksm_setup();
>
>