2023-09-26 16:54:58

by Rob Herring

[permalink] [raw]
Subject: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas

Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
index 36d97fb87865..9c36afc7084b 100644
--- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
+++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
@@ -51,6 +51,8 @@ properties:
ethaddr:
type: object
description: Ethernet interfaces base MAC address.
+ additionalProperties: false
+
properties:
"#nvmem-cell-cells":
description: The first argument is a MAC address offset.
--
2.40.1


2023-09-27 17:09:43

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas

On Tue, Sep 26, 2023 at 11:45:25AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Signed-off-by: Rob Herring <[email protected]>



Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.


Attachments:
(No filename) (430.00 B)
signature.asc (235.00 B)
Download all attachments

2023-09-28 11:31:54

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas

On 2023-09-26 18:45, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Signed-off-by: Rob Herring <[email protected]>

Thanks!

Acked-by: Rafał Miłecki <[email protected]>

2023-10-07 10:23:41

by Srinivas Kandagatla

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas


On Tue, 26 Sep 2023 11:45:25 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
>

Applied, thanks!

[1/1] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
commit: 8beb2ec54b65eb08891c9b9c23428712d46d8e15

Best regards,
--
Srinivas Kandagatla <[email protected]>