On Wednesday, 20 March 2024 19:53:50 CET Ayush Tiwari wrote:
> Change data type of local variable blnPending from u8 to bool since it
> only assumes 0 or 1 values.
>
> Signed-off-by: Ayush Tiwari <[email protected]>
> ---
> drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c
> b/drivers/staging/rtl8712/rtl8712_cmd.c index bb7db96ed821..32d9927981aa
> 100644
> --- a/drivers/staging/rtl8712/rtl8712_cmd.c
> +++ b/drivers/staging/rtl8712/rtl8712_cmd.c
> @@ -284,7 +284,7 @@ int r8712_cmd_thread(void *context)
> pcmd = cmd_hdl_filter(padapter, pcmd);
> if (pcmd) { /* if pcmd != NULL, cmd will be handled by
f/w */
> struct dvobj_priv *pdvobj = &padapter-
>dvobjpriv;
> - u8 blnPending = 0;
> + bool blnPending = 0;
bool types should take only 'true' and 'false' values. Therefore, if you
change a type to 'bool' you should also convert the values it is assigned
throughout its lifetime.
Fabio
P.S.: I just recalled that Dan has asked you to drop that 'b' prefix and do
exactly what I wrote above. Are you going to ignore his comments?
> u16 cmdcode = pcmd->cmdcode;
>
> pcmdpriv->cmd_issued_cnt++;