2020-03-05 01:38:48

by Tang Bin

Subject: [PATCH v2]tty:serial:mvebu-uart:fix a wrong return

--v1------------------------------------
in this place,the right return should be
return PTR_ERR(),not return -PTR_ERR()

--v2------------------------------------
in this place, the function should return a
negative value and the PTR_ERR already returns
a negative,so return -PTR_ERR() is wrong.

Signed-off-by: tangbin <[email protected]>
---
drivers/tty/serial/mvebu-uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
index c12a12556..4e9a59071 100644
--- a/drivers/tty/serial/mvebu-uart.c
+++ b/drivers/tty/serial/mvebu-uart.c
@@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)

port->membase = devm_ioremap_resource(&pdev->dev, reg);
if (IS_ERR(port->membase))
- return -PTR_ERR(port->membase);
+ return PTR_ERR(port->membase);

mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
GFP_KERNEL);
--
2.20.1.windows.1

2020-03-05 06:09:56

by Jiri Slaby

Subject: Re: [PATCH v2]tty:serial:mvebu-uart:fix a wrong return

On 05. 03. 20, 2:38, tangbin wrote:
> in this place, the function should return a
> negative value and the PTR_ERR already returns
> a negative,so return -PTR_ERR() is wrong.
>
> Signed-off-by: tangbin <[email protected]>

Acked-by: Jiri Slaby <[email protected]>

> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index c12a12556..4e9a59071 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
>
> port->membase = devm_ioremap_resource(&pdev->dev, reg);
> if (IS_ERR(port->membase))
> - return -PTR_ERR(port->membase);
> + return PTR_ERR(port->membase);
>
> mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
> GFP_KERNEL);
>

thanks,
--
js
suse labs