2008-08-14 16:28:18

by Jiri Slaby

Subject: [PATCH 1/1] NET: e100, fix iomap read

There were 2 omitted readb's used on an iomap space. eliminate them
by using ioread8 instead.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Jeff Kirsher <[email protected]>
Cc: Jesse Brandeburg <[email protected]>
Cc: Bruce Allan <[email protected]>
Cc: PJ Waskiewicz <[email protected]>
Cc: John Ronciak <[email protected]>
---
drivers/net/e100.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 7fee644..d7711d8 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -1727,7 +1727,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
if ((le16_to_cpu(rfd->command) & cb_el) &&
(RU_RUNNING == nic->ru_running))

- if (readb(&nic->csr->scb.status) & rus_no_res)
+ if (ioread8(&nic->csr->scb.status) & rus_no_res)
nic->ru_running = RU_SUSPENDED;
return -ENODATA;
}
@@ -1750,7 +1750,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
if ((le16_to_cpu(rfd->command) & cb_el) &&
(RU_RUNNING == nic->ru_running)) {

- if (readb(&nic->csr->scb.status) & rus_no_res)
+ if (ioread8(&nic->csr->scb.status) & rus_no_res)
nic->ru_running = RU_SUSPENDED;
}

--
1.5.6.5

2008-08-14 16:29:57

by Jesse Brandeburg

Subject: RE: [PATCH 1/1] NET: e100, fix iomap read

Jiri Slaby wrote:
> There were 2 omitted readb's used on an iomap space. eliminate them
> by using ioread8 instead.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Jeff Kirsher <[email protected]>
> Cc: Jesse Brandeburg <[email protected]>
> Cc: Bruce Allan <[email protected]>
> Cc: PJ Waskiewicz <[email protected]>
> Cc: John Ronciak <[email protected]>

Acked-by: Jesse Brandeburg <[email protected]>

2008-08-27 09:56:31

by Jeff Garzik

Subject: Re: [PATCH 1/1] NET: e100, fix iomap read

Jiri Slaby wrote:
> There were 2 omitted readb's used on an iomap space. eliminate them
> by using ioread8 instead.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Jeff Kirsher <[email protected]>
> Cc: Jesse Brandeburg <[email protected]>
> Cc: Bruce Allan <[email protected]>
> Cc: PJ Waskiewicz <[email protected]>
> Cc: John Ronciak <[email protected]>
> ---
> drivers/net/e100.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

applied