2018-07-02 07:11:54

by Colin King

Subject: [PATCH] kvmclock: remove redundant variable 'size'

From: Colin Ian King <[email protected]>

Variable size is being assigned but is never used hence it is redundant
and can be removed.

Cleans up clang warning:
warning: variable ‘size’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <[email protected]>
---
arch/x86/kernel/kvmclock.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index bf8d1eb7fca3..45c22ce941c1 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -354,13 +354,10 @@ int __init kvm_setup_vsyscall_timeinfo(void)
int cpu;
u8 flags;
struct pvclock_vcpu_time_info *vcpu_time;
- unsigned int size;

if (!hv_clock)
return 0;

- size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
-
cpu = get_cpu();

vcpu_time = &hv_clock[cpu].pvti;
--
2.17.1

2018-07-02 15:58:22

by Liam Merwick

Subject: Re: [PATCH] kvmclock: remove redundant variable 'size'

On 02/07/18 08:06, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable size is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
>

Is it worth adding

Fixes: cc1e24fdb064 ("x86/vdso: Remove pvclock fixmap machinery")

> Signed-off-by: Colin Ian King <[email protected]>

either way

Reviewed-by: Liam Merwick <[email protected]>

> ---
> arch/x86/kernel/kvmclock.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index bf8d1eb7fca3..45c22ce941c1 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -354,13 +354,10 @@ int __init kvm_setup_vsyscall_timeinfo(void)
> int cpu;
> u8 flags;
> struct pvclock_vcpu_time_info *vcpu_time;
> - unsigned int size;
>
> if (!hv_clock)
> return 0;
>
> - size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
> -
> cpu = get_cpu();
>
> vcpu_time = &hv_clock[cpu].pvti;
>

2018-07-04 21:45:00

by David Hildenbrand

Subject: Re: [PATCH] kvmclock: remove redundant variable 'size'

On 02.07.2018 09:06, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable size is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> arch/x86/kernel/kvmclock.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index bf8d1eb7fca3..45c22ce941c1 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -354,13 +354,10 @@ int __init kvm_setup_vsyscall_timeinfo(void)
> int cpu;
> u8 flags;
> struct pvclock_vcpu_time_info *vcpu_time;
> - unsigned int size;
>
> if (!hv_clock)
> return 0;
>
> - size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
> -
> cpu = get_cpu();
>
> vcpu_time = &hv_clock[cpu].pvti;
>

Reviewed-by: David Hildenbrand <[email protected]>

--

Thanks,

David / dhildenb