2020-12-22 13:35:56

by Zheng Yongjun

Subject: [PATCH -next] f2fs: Replace expression with offsetof()

Use the existing offsetof() macro instead of duplicating code.

Signed-off-by: Zheng Yongjun <[email protected]>
---
fs/f2fs/node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index d5d8ce077f29..000cafb522ec 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2686,7 +2686,7 @@ int f2fs_recover_inode_page(struct f2fs_sb_info *sbi, struct page *page)
src = F2FS_INODE(page);
dst = F2FS_INODE(ipage);

- memcpy(dst, src, (unsigned long)&src->i_ext - (unsigned long)src);
+ memcpy(dst, src, offsetof(struct f2fs_inode, i_ext));
dst->i_size = 0;
dst->i_blocks = cpu_to_le64(1);
dst->i_links = cpu_to_le32(1);
--
2.22.0

2020-12-24 02:54:39

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH -next] f2fs: Replace expression with offsetof()

On 2020/12/22 21:34, Zheng Yongjun wrote:
> Use the existing offsetof() macro instead of duplicating code.
>
> Signed-off-by: Zheng Yongjun <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,