2021-03-04 17:18:41

by Paul Menzel

[permalink] [raw]
Subject: [PATCH] kexec: Add kexec reboot string

From: Joe LeVeque <[email protected]>

The purpose is to notify the kernel module for fast reboot.

Upstream a patch from the SONiC network operating system [1].

[1]: https://github.com/Azure/sonic-linux-kernel/pull/46

Signed-off-by: Paul Menzel <[email protected]>
---
kernel/kexec_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index a0b6780740c8..f04d04d1b855 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -1165,7 +1165,7 @@ int kernel_kexec(void)
#endif
{
kexec_in_progress = true;
- kernel_restart_prepare(NULL);
+ kernel_restart_prepare("kexec reboot");
migrate_to_reboot_cpu();

/*
--
2.30.1


2021-03-11 04:14:53

by Baoquan He

[permalink] [raw]
Subject: Re: [PATCH] kexec: Add kexec reboot string

On 03/04/21 at 01:46pm, Paul Menzel wrote:
> From: Joe LeVeque <[email protected]>
>
> The purpose is to notify the kernel module for fast reboot.

Checked several modules which registered with reboot_notifier_list, the
passed string is not cared. Just curious, could you tell how you have
used or plan to use this string in your code?

No objection to this even though it's trivial if no real use case.

Acked-by: Baoquan He <[email protected]>

>
> Upstream a patch from the SONiC network operating system [1].
>
> [1]: https://github.com/Azure/sonic-linux-kernel/pull/46
>
> Signed-off-by: Paul Menzel <[email protected]>
> ---
> kernel/kexec_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index a0b6780740c8..f04d04d1b855 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1165,7 +1165,7 @@ int kernel_kexec(void)
> #endif
> {
> kexec_in_progress = true;
> - kernel_restart_prepare(NULL);
> + kernel_restart_prepare("kexec reboot");
> migrate_to_reboot_cpu();
>
> /*
> --
> 2.30.1
>
>
> _______________________________________________
> kexec mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/kexec
>

2021-03-11 05:38:04

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] kexec: Add kexec reboot string

On Thu, 4 Mar 2021 13:46:26 +0100 Paul Menzel <[email protected]> wrote:

> From: Joe LeVeque <[email protected]>
>
> The purpose is to notify the kernel module for fast reboot.
>
> Upstream a patch from the SONiC network operating system [1].
>
> [1]: https://github.com/Azure/sonic-linux-kernel/pull/46
>
> Signed-off-by: Paul Menzel <[email protected]>

We should have Joe's signed-off-by: for this. Joe, can you please send
it?

2021-03-11 18:17:57

by Joe LeVeque

[permalink] [raw]
Subject: RE: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string

Hi Andrew,

Is this all your looking for? If not, please let me know.

> Signed-off-by: Joe LeVeque <[email protected]>

Thanks,
Joe

-----Original Message-----
From: Andrew Morton <[email protected]>
Sent: Wednesday, March 10, 2021 9:33 PM
To: Paul Menzel <[email protected]>
Cc: Eric Biederman <[email protected]>; [email protected]; [email protected]; Guohan Lu <[email protected]>; Joe LeVeque <[email protected]>
Subject: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string

On Thu, 4 Mar 2021 13:46:26 +0100 Paul Menzel <[email protected]> wrote:

> From: Joe LeVeque <[email protected]>
>
> The purpose is to notify the kernel module for fast reboot.
>
> Upstream a patch from the SONiC network operating system [1].
>
> [1]:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2FAzure%2Fsonic-linux-kernel%2Fpull%2F46&amp;data=04%7C01%7Cjol
> evequ%40microsoft.com%7Cddd7ea68d7d14ecdbd6608d8e44f225b%7C72f988bf86f
> 141af91ab2d7cd011db47%7C1%7C0%7C637510375952624615%7CUnknown%7CTWFpbGZ
> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C1000&amp;sdata=0lxaoVz%2BYyu5C4HvzSGMf0NpJJUWZFWdp7m3hLlL9MM%3D&am
> p;reserved=0
>
> Signed-off-by: Paul Menzel <[email protected]>

We should have Joe's signed-off-by: for this. Joe, can you please send it?

2021-03-11 20:57:28

by Andrew Morton

[permalink] [raw]
Subject: Re: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string

On Thu, 11 Mar 2021 18:14:19 +0000 Joe LeVeque <[email protected]> wrote:

> Is this all your looking for? If not, please let me know.
>
> > Signed-off-by: Joe LeVeque <[email protected]>

Yes, thanks.

2021-03-11 21:13:32

by Paul Menzel

[permalink] [raw]
Subject: Re: [EXTERNAL] Re: [PATCH] kexec: Add kexec reboot string

Dear Joe,


Thank you for replying.


Am 11.03.21 um 19:14 schrieb Joe LeVeque:

> Is this all your looking for? If not, please let me know.
>
>> Signed-off-by: Joe LeVeque <[email protected]>

It’d be great if you answered Baoquan He’s question, how it’s actually
used in SONiC. (I just sent the patch upstream to reduce the out-of-tree
patches in SONiC.)


Kind regards,

Paul