2021-11-19 13:43:38

by Chris Clayton

[permalink] [raw]
Subject: Intel bluetooth regression in 5.15.3

Hi,

I built and installed 5.15.3 this morning and found that my bluetooth devices no longer work. 5.15.2 and 5.10.80 are
both OK.

I've bisected it and landed on:

cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039 is the first bad commit
commit cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039
Author: Rafael J. Wysocki <[email protected]>
Date: Sat Oct 9 16:22:09 2021 +0200

ACPI: scan: Release PM resources blocked by unused objects

[ Upstream commit c10383e8ddf4810b9a5c1595404c2724d925a0a6 ]

On some systems the ACPI namespace contains device objects that are
not used in certain configurations of the system. If they start off
in the D0 power state configuration, they will stay in it until the
system reboots, because of the lack of any mechanism possibly causing
their configuration to change. If that happens, they may prevent
some power resources from being turned off or generally they may
prevent the platform from getting into the deepest low-power states
thus causing some energy to be wasted.

Address this issue by changing the configuration of unused ACPI
device objects to the D3cold power state one after carrying out
the ACPI-based enumeration of devices.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214091
Link: https://lore.kernel.org/linux-acpi/[email protected]/
Reported-by: Mario Limonciello <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
Tested-by: Mario Limonciello <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>

drivers/acpi/glue.c | 25 +++++++++++++++++++++++++
drivers/acpi/internal.h | 1 +
drivers/acpi/scan.c | 6 ++++++
3 files changed, 32 insertions(+)

5.15.3 with that commit reverted works fine.

Let me know if you need any additional diagnostics or patches tested but please cc me as I'm not subscribed.

Chris


2021-11-19 14:37:02

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: Intel bluetooth regression in 5.15.3

On Fri, Nov 19, 2021 at 01:43:32PM +0000, Chris Clayton wrote:
> Hi,
>
> I built and installed 5.15.3 this morning and found that my bluetooth devices no longer work. 5.15.2 and 5.10.80 are
> both OK.
>
> I've bisected it and landed on:
>
> cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039 is the first bad commit
> commit cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039
> Author: Rafael J. Wysocki <[email protected]>
> Date: Sat Oct 9 16:22:09 2021 +0200
>
> ACPI: scan: Release PM resources blocked by unused objects
>
> [ Upstream commit c10383e8ddf4810b9a5c1595404c2724d925a0a6 ]
>
> On some systems the ACPI namespace contains device objects that are
> not used in certain configurations of the system. If they start off
> in the D0 power state configuration, they will stay in it until the
> system reboots, because of the lack of any mechanism possibly causing
> their configuration to change. If that happens, they may prevent
> some power resources from being turned off or generally they may
> prevent the platform from getting into the deepest low-power states
> thus causing some energy to be wasted.
>
> Address this issue by changing the configuration of unused ACPI
> device objects to the D3cold power state one after carrying out
> the ACPI-based enumeration of devices.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214091
> Link: https://lore.kernel.org/linux-acpi/[email protected]/
> Reported-by: Mario Limonciello <[email protected]>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> Tested-by: Mario Limonciello <[email protected]>
> Signed-off-by: Sasha Levin <[email protected]>
>
> drivers/acpi/glue.c | 25 +++++++++++++++++++++++++
> drivers/acpi/internal.h | 1 +
> drivers/acpi/scan.c | 6 ++++++
> 3 files changed, 32 insertions(+)
>
> 5.15.3 with that commit reverted works fine.
>
> Let me know if you need any additional diagnostics or patches tested but please cc me as I'm not subscribed.

Is 5.16-rc1 also a problem for you and your devices?

thanks,

greg k-h

2021-11-19 15:32:37

by Chris Clayton

[permalink] [raw]
Subject: Re: Intel bluetooth regression in 5.15.3



On 19/11/2021 14:36, Greg Kroah-Hartman wrote:
> On Fri, Nov 19, 2021 at 01:43:32PM +0000, Chris Clayton wrote:
>> Hi,
>>
>> I built and installed 5.15.3 this morning and found that my bluetooth devices no longer work. 5.15.2 and 5.10.80 are
>> both OK.
>>
>> I've bisected it and landed on:
>>
>> cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039 is the first bad commit
>> commit cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039
>> Author: Rafael J. Wysocki <[email protected]>
>> Date: Sat Oct 9 16:22:09 2021 +0200
>>
>> ACPI: scan: Release PM resources blocked by unused objects
>>
>> [ Upstream commit c10383e8ddf4810b9a5c1595404c2724d925a0a6 ]
>>
>> On some systems the ACPI namespace contains device objects that are
>> not used in certain configurations of the system. If they start off
>> in the D0 power state configuration, they will stay in it until the
>> system reboots, because of the lack of any mechanism possibly causing
>> their configuration to change. If that happens, they may prevent
>> some power resources from being turned off or generally they may
>> prevent the platform from getting into the deepest low-power states
>> thus causing some energy to be wasted.
>>
>> Address this issue by changing the configuration of unused ACPI
>> device objects to the D3cold power state one after carrying out
>> the ACPI-based enumeration of devices.
>>
>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214091
>> Link: https://lore.kernel.org/linux-acpi/[email protected]/
>> Reported-by: Mario Limonciello <[email protected]>
>> Signed-off-by: Rafael J. Wysocki <[email protected]>
>> Tested-by: Mario Limonciello <[email protected]>
>> Signed-off-by: Sasha Levin <[email protected]>
>>
>> drivers/acpi/glue.c | 25 +++++++++++++++++++++++++
>> drivers/acpi/internal.h | 1 +
>> drivers/acpi/scan.c | 6 ++++++
>> 3 files changed, 32 insertions(+)
>>
>> 5.15.3 with that commit reverted works fine.
>>
>> Let me know if you need any additional diagnostics or patches tested but please cc me as I'm not subscribed.
>
> Is 5.16-rc1 also a problem for you and your devices?
>
> thanks,
>

No, 5.16-rc1+, built after a git pull just a few minutes ago, woks fine. Looking at Linus's tree, the commit I
identified in the bisection was reverted a couple of days ago (commit 3b2b49e6dfdcf423506a771bf44cee842596351a).

Thanks

Chris
> greg k-h
>

2021-11-19 17:04:14

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: Intel bluetooth regression in 5.15.3

On Fri, Nov 19, 2021 at 03:32:28PM +0000, Chris Clayton wrote:
>
>
> On 19/11/2021 14:36, Greg Kroah-Hartman wrote:
> > On Fri, Nov 19, 2021 at 01:43:32PM +0000, Chris Clayton wrote:
> >> Hi,
> >>
> >> I built and installed 5.15.3 this morning and found that my bluetooth devices no longer work. 5.15.2 and 5.10.80 are
> >> both OK.
> >>
> >> I've bisected it and landed on:
> >>
> >> cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039 is the first bad commit
> >> commit cfc1a472a8d89c0d0bbb3600501eeeebc5ec8039
> >> Author: Rafael J. Wysocki <[email protected]>
> >> Date: Sat Oct 9 16:22:09 2021 +0200
> >>
> >> ACPI: scan: Release PM resources blocked by unused objects
> >>
> >> [ Upstream commit c10383e8ddf4810b9a5c1595404c2724d925a0a6 ]
> >>
> >> On some systems the ACPI namespace contains device objects that are
> >> not used in certain configurations of the system. If they start off
> >> in the D0 power state configuration, they will stay in it until the
> >> system reboots, because of the lack of any mechanism possibly causing
> >> their configuration to change. If that happens, they may prevent
> >> some power resources from being turned off or generally they may
> >> prevent the platform from getting into the deepest low-power states
> >> thus causing some energy to be wasted.
> >>
> >> Address this issue by changing the configuration of unused ACPI
> >> device objects to the D3cold power state one after carrying out
> >> the ACPI-based enumeration of devices.
> >>
> >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214091
> >> Link: https://lore.kernel.org/linux-acpi/[email protected]/
> >> Reported-by: Mario Limonciello <[email protected]>
> >> Signed-off-by: Rafael J. Wysocki <[email protected]>
> >> Tested-by: Mario Limonciello <[email protected]>
> >> Signed-off-by: Sasha Levin <[email protected]>
> >>
> >> drivers/acpi/glue.c | 25 +++++++++++++++++++++++++
> >> drivers/acpi/internal.h | 1 +
> >> drivers/acpi/scan.c | 6 ++++++
> >> 3 files changed, 32 insertions(+)
> >>
> >> 5.15.3 with that commit reverted works fine.
> >>
> >> Let me know if you need any additional diagnostics or patches tested but please cc me as I'm not subscribed.
> >
> > Is 5.16-rc1 also a problem for you and your devices?
> >
> > thanks,
> >
>
> No, 5.16-rc1+, built after a git pull just a few minutes ago, woks fine. Looking at Linus's tree, the commit I
> identified in the bisection was reverted a couple of days ago (commit 3b2b49e6dfdcf423506a771bf44cee842596351a).

Ah, good, I'll go queue that up right now, thanks.

greg k-h