2024-05-17 23:26:31

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

From: "Dr. David Alan Gilbert" <[email protected]>

'init_exec' is unused since
commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
init table parser")
Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 79cfab53f80e..8c3c1f1e01c5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -43,11 +43,6 @@
#define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
#define LOG_OLD_VALUE(x)

-struct init_exec {
- bool execute;
- bool repeat;
-};
-
static bool nv_cksum(const uint8_t *data, unsigned int length)
{
/*
--
2.45.1



2024-06-03 17:38:50

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

* [email protected] ([email protected]) wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'init_exec' is unused since
> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> init table parser")
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Ping.


> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 79cfab53f80e..8c3c1f1e01c5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -43,11 +43,6 @@
> #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
> #define LOG_OLD_VALUE(x)
>
> -struct init_exec {
> - bool execute;
> - bool repeat;
> -};
> -
> static bool nv_cksum(const uint8_t *data, unsigned int length)
> {
> /*
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/

2024-06-11 10:02:28

by Danilo Krummrich

[permalink] [raw]
Subject: Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

On 5/18/24 01:26, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'init_exec' is unused since
> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> init table parser")
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Acked-by: Danilo Krummrich <[email protected]>

To which series does this patch belong? Need me to apply it?

- Danilo

> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 79cfab53f80e..8c3c1f1e01c5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -43,11 +43,6 @@
> #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
> #define LOG_OLD_VALUE(x)
>
> -struct init_exec {
> - bool execute;
> - bool repeat;
> -};
> -
> static bool nv_cksum(const uint8_t *data, unsigned int length)
> {
> /*


2024-06-11 10:38:30

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

* Danilo Krummrich ([email protected]) wrote:
> On 5/18/24 01:26, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'init_exec' is unused since
> > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> > init table parser")
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
>
> Acked-by: Danilo Krummrich <[email protected]>
>
> To which series does this patch belong?

Actually all of them were independent patches on drm
some of which are all in, so it can be taken by itself.

> Need me to apply it?

Yes please!

Thanks,

Dave

> - Danilo
>
> > ---
> > drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> > index 79cfab53f80e..8c3c1f1e01c5 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> > @@ -43,11 +43,6 @@
> > #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
> > #define LOG_OLD_VALUE(x)
> > -struct init_exec {
> > - bool execute;
> > - bool repeat;
> > -};
> > -
> > static bool nv_cksum(const uint8_t *data, unsigned int length)
> > {
> > /*
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/

2024-06-11 21:24:42

by Danilo Krummrich

[permalink] [raw]
Subject: Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

On 6/11/24 12:37, Dr. David Alan Gilbert wrote:
> * Danilo Krummrich ([email protected]) wrote:
>> On 5/18/24 01:26, [email protected] wrote:
>>> From: "Dr. David Alan Gilbert" <[email protected]>
>>>
>>> 'init_exec' is unused since
>>> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
>>> init table parser")
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
>>
>> Acked-by: Danilo Krummrich <[email protected]>
>>
>> To which series does this patch belong?
>
> Actually all of them were independent patches on drm
> some of which are all in, so it can be taken by itself.
>
>> Need me to apply it?
>
> Yes please!

Applied to drm-misc-fixes, thanks!

>
> Thanks,
>
> Dave
>
>> - Danilo
>>
>>> ---
>>> drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> index 79cfab53f80e..8c3c1f1e01c5 100644
>>> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> @@ -43,11 +43,6 @@
>>> #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
>>> #define LOG_OLD_VALUE(x)
>>> -struct init_exec {
>>> - bool execute;
>>> - bool repeat;
>>> -};
>>> -
>>> static bool nv_cksum(const uint8_t *data, unsigned int length)
>>> {
>>> /*
>>