2023-07-26 13:51:36

by Wang Ming

Subject: [PATCH v3] reset: hisilicon: Use dev_err_probe instead of dev_err

The probe process may generate EPROBE_DEFER. In this case,
dev_err_probe can still record err information.
This helps simplify code and standardize error output.

Signed-off-by: Wang Ming <[email protected]>
---
drivers/reset/hisilicon/reset-hi3660.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/hisilicon/reset-hi3660.c b/drivers/reset/hisilicon/reset-hi3660.c
index 965f5ceba7d8..22a9f87b4979 100644
--- a/drivers/reset/hisilicon/reset-hi3660.c
+++ b/drivers/reset/hisilicon/reset-hi3660.c
@@ -90,8 +90,8 @@ static int hi3660_reset_probe(struct platform_device *pdev)
"hisi,rst-syscon");
}
if (IS_ERR(rc->map)) {
- dev_err(dev, "failed to get hisilicon,rst-syscon\n");
- return PTR_ERR(rc->map);
+ return dev_err_probe(dev, PTR_ERR(rc->map),
+ "failed to get hisilicon,rst-syscon\n");
}

rc->rst.ops = &hi3660_reset_ops,
--
2.25.1

2023-08-08 19:11:20

by Philipp Zabel

Subject: Re: [PATCH v3] reset: hisilicon: Use dev_err_probe instead of dev_err

On Mi, 2023-07-26 at 19:45 +0800, Wang Ming wrote:
> The probe process may generate EPROBE_DEFER. In this case,
> dev_err_probe can still record err information.
> This helps simplify code and standardize error output.
>
> Signed-off-by: Wang Ming <[email protected]>

Thank you, applied to reset/next.

regards
Philipp