2023-09-12 21:29:47

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v6 1/2] dt-bindings: arm64: dts: mediatek: add mt8395-evk board

On 11/09/2023 13:57, Macpaul Lin wrote:
> 1. Add compatible for MT8395.
> 2. Add bindings for the MediaTek mt8395-evk board, also known
> as the "Genio 1200-EVK".
>
> The MT8195 and MT8395 belong to the same SoC family,
> with only minor differences in their physical characteristics.
> They utilize unique efuse values for differentiation.
>
> The booting process and configurations are managed by boot
> loaders, firmware, and TF-A. Consequently, the part numbers
> and procurement channels vary.
>
> Signed-off-by: Macpaul Lin <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> Changes for v2:
> - add more detail description for mt8395.
> - add bindings for mt8395, and mt8395-evk.
>
> Changes for v3:
> - add back bindings for mt8195 compatible.
>
> Changes for v4:
> Changes for v5:
> Changes for v6:
> - No change, update Reviewed-by tag only. Thanks.
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index ae12b1cab9fb..2e8ad49c3479 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -248,6 +248,12 @@ properties:
> - enum:
> - mediatek,mt8365-evk
> - const: mediatek,mt8365
> + - description: MediaTek Genio 1200 Boards (Genio 1200 EVK)

Drop description. This is an entry for multiple boards, not only for
this one.

Best regards,
Krzysztof


2023-09-13 23:14:33

by Macpaul Lin

[permalink] [raw]
Subject: Re: [PATCH v6 1/2] dt-bindings: arm64: dts: mediatek: add mt8395-evk board

On 9/12/23 22:36, Krzysztof Kozlowski wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On 11/09/2023 13:57, Macpaul Lin wrote:
>> 1. Add compatible for MT8395.
>> 2. Add bindings for the MediaTek mt8395-evk board, also known
>> as the "Genio 1200-EVK".
>>
>> The MT8195 and MT8395 belong to the same SoC family,
>> with only minor differences in their physical characteristics.
>> They utilize unique efuse values for differentiation.
>>
>> The booting process and configurations are managed by boot
>> loaders, firmware, and TF-A. Consequently, the part numbers
>> and procurement channels vary.
>>
>> Signed-off-by: Macpaul Lin <[email protected]>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> Changes for v2:
>> - add more detail description for mt8395.
>> - add bindings for mt8395, and mt8395-evk.
>>
>> Changes for v3:
>> - add back bindings for mt8195 compatible.
>>
>> Changes for v4:
>> Changes for v5:
>> Changes for v6:
>> - No change, update Reviewed-by tag only. Thanks.
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index ae12b1cab9fb..2e8ad49c3479 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -248,6 +248,12 @@ properties:
>> - enum:
>> - mediatek,mt8365-evk
>> - const: mediatek,mt8365
>> + - description: MediaTek Genio 1200 Boards (Genio 1200 EVK)
>
> Drop description. This is an entry for multiple boards, not only for
> this one.
>
> Best regards,
> Krzysztof
>

Ok, will drop this line and send v7 series.

Thanks
Macpaul Lin