2020-10-19 19:07:11

by Kent Overstreet

Subject: [PATCH 1/2] block: Add some exports for bcachefs

bcachefs has its own direct IO code.

Signed-off-by: Kent Overstreet <[email protected]>
---
block/bio.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/block/bio.c b/block/bio.c
index e865ea55b9..72a65c4113 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1320,6 +1320,7 @@ void bio_set_pages_dirty(struct bio *bio)
set_page_dirty_lock(bvec->bv_page);
}
}
+EXPORT_SYMBOL_GPL(bio_set_pages_dirty);

/*
* bio_check_pages_dirty() will check that all the BIO's pages are still dirty.
@@ -1379,6 +1380,7 @@ void bio_check_pages_dirty(struct bio *bio)
spin_unlock_irqrestore(&bio_dirty_lock, flags);
schedule_work(&bio_dirty_work);
}
+EXPORT_SYMBOL_GPL(bio_check_pages_dirty);

static inline bool bio_remaining_done(struct bio *bio)
{
--
2.28.0

2020-10-20 07:39:07

by Jens Axboe

Subject: Re: [PATCH 1/2] block: Add some exports for bcachefs

On 10/19/20 1:02 PM, Kent Overstreet wrote:
> bcachefs has its own direct IO code.

I talked to Kent about this offline, but just for completeness sake,
my recommendation is to keep these as prep patches for the bcachefs
series so we avoid having modular exports of code that don't have
any in-kernel modular users.

--
Jens Axboe