2007-06-12 03:09:47

by Wu Fengguang

Subject: [PATCH 0/2] readahead update on splice reads

Andrew,

The two patches optimizes readahead invocations in splice reads:

readahead: move synchronous readahead call out of splice loop
readahead: pass real splice size

They can be appended to readahead-convert-splice-invocations.patch in -mm tree.


diffstat:

fs/splice.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)

Regards,
Fengguang
--

2007-06-12 06:42:41

by Jens Axboe

Subject: Re: [PATCH 0/2] readahead update on splice reads

On Tue, Jun 12 2007, Fengguang Wu wrote:
> Andrew,
>
> The two patches optimizes readahead invocations in splice reads:
>
> readahead: move synchronous readahead call out of splice loop
> readahead: pass real splice size
>
> They can be appended to readahead-convert-splice-invocations.patch in
> -mm tree.

Patches look nice, but unfortunately only -mm stuff and will need to be
rebased once 2.6.23 opens anyway.

Where are we on the ondemand read-ahead merging? -mm has continually had
different read-ahead code than mainline now for seemingly years, seems a
bit pointless to me. Either we get the stuff merged, or toss it out.
Nothing needs to simmer that long.

I suspect we wont see any real potential regressions before it hits
mainline anyway.

--
Jens Axboe