2022-11-07 11:23:23

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v2 0/3] RNG clock property cleanup

This series removes the clock property from the rng node of
K3 devices for TI SoCs as that clock is not dedicated to RNG
module and it cannot be controlled by the rng driver.

DT binding fix:
<https://lore.kernel.org/all/[email protected]/>

Changelog v1 -> v2:
- Update the commit description properly for each patch

Jayesh Choudhary (3):
arm64: dts: ti: k3-am65-main: drop RNG clock
arm64: dts: ti: k3-j721e-main: drop RNG clock
arm64: dts: ti: k3-am64-main: drop RNG clock

arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 1 -
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
3 files changed, 3 deletions(-)

--
2.25.1



2022-11-07 11:45:24

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: ti: k3-am64-main: drop RNG clock

The x1-clk used by trng submodule comes directly from the system clock
after a fixed divider. It is always running and has a fixed frequency
that cannot be changed, making it uncontrollable. Hence this property
should be dropped from the rng node.

Fixes: e170ae6dd67a ("arm64: dts: ti: k3-am64-main: Enable crypto accelerator")
Signed-off-by: Jayesh Choudhary <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index c96df4b9b3d7..ac04cf1d9c3e 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -1359,7 +1359,6 @@ rng: rng@40910000 {
compatible = "inside-secure,safexcel-eip76";
reg = <0x00 0x40910000 0x00 0x7d>;
interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&k3_clks 133 1>;
status = "disabled"; /* Used by OP-TEE */
};
};
--
2.25.1


2022-11-07 11:47:21

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v2 2/3] arm64: dts: ti: k3-j721e-main: drop RNG clock

The x1-clk used by trng submodule comes directly from the system clock
after a fixed divider. It is always running and has a fixed frequency
that cannot be changed, making it uncontrollable. Hence this property
should be dropped from the rng node.

Fixes: 8ebcaaae8017 ("arm64: dts: ti: k3-j721e-main: Add crypto accelerator node")
Signed-off-by: Jayesh Choudhary <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 5c4a0e28cde5..f1403b79e7f5 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -355,7 +355,6 @@ rng: rng@4e10000 {
compatible = "inside-secure,safexcel-eip76";
reg = <0x0 0x4e10000 0x0 0x7d>;
interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&k3_clks 264 2>;
};
};

--
2.25.1


2022-11-16 04:40:09

by Manorit Chawdhry

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] RNG clock property cleanup


On 07/11/22 16:36, Jayesh Choudhary wrote:
> This series removes the clock property from the rng node of
> K3 devices for TI SoCs as that clock is not dedicated to RNG
> module and it cannot be controlled by the rng driver.
>
> DT binding fix:
> <https://lore.kernel.org/all/[email protected]/>
>
> Changelog v1 -> v2:
> - Update the commit description properly for each patch
>
> Jayesh Choudhary (3):
> arm64: dts: ti: k3-am65-main: drop RNG clock
> arm64: dts: ti: k3-j721e-main: drop RNG clock
> arm64: dts: ti: k3-am64-main: drop RNG clock
>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
> 3 files changed, 3 deletions(-)
>
For the whole series,

Reviewed-by: Manorit Chawdhry <[email protected]>


2022-11-17 07:39:36

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] RNG clock property cleanup

Hi Jayesh Choudhary,

On Mon, 7 Nov 2022 16:36:04 +0530, Jayesh Choudhary wrote:
> This series removes the clock property from the rng node of
> K3 devices for TI SoCs as that clock is not dedicated to RNG
> module and it cannot be controlled by the rng driver.
>
> DT binding fix:
> <https://lore.kernel.org/all/[email protected]/>
>
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

Couple of minor things:
a) cover letter suggestion: for the usual arm64: dts: ti: ... convention - it
is useful for folks who are'nt aware to understand which subsystem the series
goes to..
b) Follow the stable-rules for using Fixes or not. I chose to drop it since it
serves no functional purpose anyways (and I would'nt call a regression esp
on a disabled node).

[1/3] arm64: dts: ti: k3-am65-main: drop RNG clock
commit: cfc75a93d7256d65c7b463620e7c13bd8219707b
[2/3] arm64: dts: ti: k3-j721e-main: drop RNG clock
commit: a315097a23eb1976e8eac397c02ada82618858bb
[3/3] arm64: dts: ti: k3-am64-main: drop RNG clock
commit: c1e56c8250a234d9bcd9e2f060da229688dfd9eb

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D