2023-04-18 15:08:04

by Colin Ian King

Subject: [PATCH][next] rv: remove redundant assignment to variable retval

Variable retval is being assigned a value that is never read, it is
being re-assigned a new value in both paths of a following if statement.
Remove the assignment.

Cleans up clang-scan warning:
kernel/trace/rv/rv.c:293:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
retval = count;

Signed-off-by: Colin Ian King <[email protected]>
---
kernel/trace/rv/rv.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/trace/rv/rv.c b/kernel/trace/rv/rv.c
index 7e9061828c24..2f68e93fff0b 100644
--- a/kernel/trace/rv/rv.c
+++ b/kernel/trace/rv/rv.c
@@ -290,8 +290,6 @@ static ssize_t monitor_enable_write_data(struct file *filp, const char __user *u
if (retval)
return retval;

- retval = count;
-
mutex_lock(&rv_interface_lock);

if (val)
--
2.30.2

2023-04-24 09:25:20

by Daniel Bristot de Oliveira

Subject: Re: [PATCH][next] rv: remove redundant assignment to variable retval

On 4/18/23 17:00, Colin Ian King wrote:
> Variable retval is being assigned a value that is never read, it is
> being re-assigned a new value in both paths of a following if statement.
> Remove the assignment.
>
> Cleans up clang-scan warning:
> kernel/trace/rv/rv.c:293:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
> retval = count;
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Daniel Bristot de Oliveira <[email protected]>

Thanks!
-- Daniel