2019-03-19 15:02:30

by Dongli Zhang

Subject: [PATCH 1/1] blk-mq: remove unused 'nr_expired' from blk_mq_hw_ctx

There is no usage of 'nr_expired'.

The 'nr_expired' was introduced by commit 1d9bd5161ba3 ("blk-mq: replace
timeout synchronization with a RCU and generation based scheme"). Its usage
was removed since commit 12f5b9314545 ("blk-mq: Remove generation
seqeunce").

Signed-off-by: Dongli Zhang <[email protected]>
---
include/linux/blk-mq.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index b0c814b..3535969 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -57,7 +57,6 @@ struct blk_mq_hw_ctx {
unsigned int queue_num;

atomic_t nr_active;
- unsigned int nr_expired;

struct hlist_node cpuhp_dead;
struct kobject kobj;
--
2.7.4

2019-03-19 15:09:15

by Jens Axboe

Subject: Re: [PATCH 1/1] blk-mq: remove unused 'nr_expired' from blk_mq_hw_ctx

On 3/19/19 9:05 AM, Dongli Zhang wrote:
> There is no usage of 'nr_expired'.
>
> The 'nr_expired' was introduced by commit 1d9bd5161ba3 ("blk-mq: replace
> timeout synchronization with a RCU and generation based scheme"). Its usage
> was removed since commit 12f5b9314545 ("blk-mq: Remove generation
> seqeunce").

Thanks, applied.

--
Jens Axboe