It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
<-- snip -->
...
CC arch/blackfin/mach-bf537/boards/stamp.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info')
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info')
make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Dec 2, 2007 8:42 AM, Adrian Bunk <[email protected]> wrote:
> It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
>
> <-- snip -->
>
> ...
> CC arch/blackfin/mach-bf537/boards/stamp.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI
header file which is in -mm tree.
David, could you please submit the Blackfin SPI update to mainline?
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info')
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info')
> make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1
>
> <-- snip -->
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
On Saturday 01 December 2007, Bryan Wu wrote:
> On Dec 2, 2007 8:42 AM, Adrian Bunk <[email protected]> wrote:
> > It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
> >
> > <-- snip -->
> >
> > ...
> > CC arch/blackfin/mach-bf537/boards/stamp.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
>
> Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI
> header file which is in -mm tree.
>
> David, could you please submit the Blackfin SPI update to mainline?
So far as I know they're all ready for Andrew to get them to Linus...
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info')
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info')
> > make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1
> >
> > <-- snip -->
> >
> > cu
> > Adrian
> >
> > --
>
On Sat, 1 Dec 2007 22:59:05 -0800 David Brownell <[email protected]> wrote:
> On Saturday 01 December 2007, Bryan Wu wrote:
> > On Dec 2, 2007 8:42 AM, Adrian Bunk <[email protected]> wrote:
> > > It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > CC arch/blackfin/mach-bf537/boards/stamp.o
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
> >
> > Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI
> > header file which is in -mm tree.
> >
> > David, could you please submit the Blackfin SPI update to mainline?
>
> So far as I know they're all ready for Andrew to get them to Linus...
>
I have all these:
spi-at25-driver-is-for-eeprom-not-flash.patch
spi-use-mutex-not-semaphore.patch
spi-simplify-spi_sync-calling-convention.patch
spi-use-simplified-spi_sync-calling-convention.patch
#
spi-initial-bf54x-spi-support.patch
spi-bfin-spi-uses-portmux-calls.patch
spi-spi_bfin-cleanups-error-handling.patch
spi-spi_bfin-handles-spi_transfercs_change.patch
spi-spi_bfin-dont-bypass-spi-framework.patch
spi-spi_bfin-uses-platform-device-resources.patch
spi-spi_bfin-uses-portmux-for-additional-busses.patch
spi-spi_bfin-rearrange-portmux-calls.patch
spi-spi_bfin-change-handling-of-communication-parameters.patch
spi-spi_bfin-relocate-spin-waits.patch
spi-spi_bfin-handle-multiple-spi_masters.patch
spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch
spi-spi_bfin-update-handling-of-delay-after-deselect.patch
spi-spi_bfin-resequence-dma-start-stop.patch
#
blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch
blackfin-spi-driver-use-void-__iomem-for-regs_base.patch
blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch
blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch
atmel_spi-throughput-improvement.patch
atmel_spi-chain-dma-transfers.patch
atmel_spi-fix-dmachain-oops-with-debug-enabled.patch
queued for 2.6.25. If some of them need to be bumped up to 2.6.24: which
ones and why?
On Saturday 01 December 2007, Andrew Morton wrote:
> I have all these:
>
> spi-at25-driver-is-for-eeprom-not-flash.patch
I'd be tempted to merge that since it's documentation-only,
and I like to see such stuff merged ASAP. But otherwise
it's non-essential.
> spi-use-mutex-not-semaphore.patch
Non-essential.
> spi-simplify-spi_sync-calling-convention.patch
> spi-use-simplified-spi_sync-calling-convention.patch
The first one fixes some minor bugs, so would be good to merge.
The second does minor associated cleanup ... non-essential.
> #
> spi-initial-bf54x-spi-support.patch
> spi-bfin-spi-uses-portmux-calls.patch
> spi-spi_bfin-cleanups-error-handling.patch
> spi-spi_bfin-handles-spi_transfercs_change.patch
> spi-spi_bfin-dont-bypass-spi-framework.patch
> spi-spi_bfin-uses-platform-device-resources.patch
> spi-spi_bfin-uses-portmux-for-additional-busses.patch
> spi-spi_bfin-rearrange-portmux-calls.patch
> spi-spi_bfin-change-handling-of-communication-parameters.patch
> spi-spi_bfin-relocate-spin-waits.patch
> spi-spi_bfin-handle-multiple-spi_masters.patch
> spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch
> spi-spi_bfin-update-handling-of-delay-after-deselect.patch
> spi-spi_bfin-resequence-dma-start-stop.patch
> #
> blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch
> blackfin-spi-driver-use-void-__iomem-for-regs_base.patch
> blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch
> blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch
The fix to the compile error is in the next-to-last of these.
Bryan says they're highly interdependent, and they also
include quite a number of bugfixes (some "critical") that
have been used in Analog's treee for many months now.
That makes sense to me, since they've been bouncing around
for quite a while now. I'd be OK with merging all of them;
if something breaks, it'd be no worse than the current state
(and would only affect Blackfin).
> atmel_spi-throughput-improvement.patch
> atmel_spi-chain-dma-transfers.patch
> atmel_spi-fix-dmachain-oops-with-debug-enabled.patch
Those can wait; they're performance updates.
> queued for 2.6.25. If some of them need to be bumped up to 2.6.24: which
> ones and why?
I'd say all those Blackfin patches should go, and the one
calling convention patch, are appropriate as bugfixes.
And the doc patch, unless there's a reason to hold it back.
- Dave