2008-01-01 13:49:54

by Adrian Bunk

Subject: [RFC: 2.6 patch] make BINFMT_FLAT a bool

I have not yet seen anyone saying he has a reasonable use case for using
BINFMT_FLAT modular on his embedded device.

Considering that fs/binfmt_flat.c even lacks a MODULE_LICENSE() I really
doubt there is any, and this patch therefore makes BINFMT_FLAT a bool.

Signed-off-by: Adrian Bunk <[email protected]>

---

fs/Kconfig.binfmt | 2 +-
fs/binfmt_flat.c | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)

5437fb7517380d1b93dde3c09dbd3a2efaf276c3
diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt
index d4fc609..c16a16c 100644
--- a/fs/Kconfig.binfmt
+++ b/fs/Kconfig.binfmt
@@ -37,7 +37,7 @@ config BINFMT_ELF_FDPIC
It is also possible to run FDPIC ELF binaries on MMU linux also.

config BINFMT_FLAT
- tristate "Kernel support for flat binaries"
+ bool "Kernel support for flat binaries"
depends on !MMU
help
Support uClinux FLAT format binaries.
diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 33764fd..274d723 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -933,14 +933,8 @@ static int __init init_flat_binfmt(void)
return register_binfmt(&flat_format);
}

-static void __exit exit_flat_binfmt(void)
-{
- unregister_binfmt(&flat_format);
-}
-
/****************************************************************************/

core_initcall(init_flat_binfmt);
-module_exit(exit_flat_binfmt);

/****************************************************************************/

2008-01-01 14:57:56

by Bryan Wu

Subject: Re: [RFC: 2.6 patch] make BINFMT_FLAT a bool

On Jan 1, 2008 9:48 PM, Adrian Bunk <[email protected]> wrote:
> I have not yet seen anyone saying he has a reasonable use case for using
> BINFMT_FLAT modular on his embedded device.
>
> Considering that fs/binfmt_flat.c even lacks a MODULE_LICENSE() I really
> doubt there is any, and this patch therefore makes BINFMT_FLAT a bool.
>

It is OK for Blackfin. There is no application using FLAT binary
format as module.

Thanks
-Bryan

> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> fs/Kconfig.binfmt | 2 +-
> fs/binfmt_flat.c | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> 5437fb7517380d1b93dde3c09dbd3a2efaf276c3
> diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt
> index d4fc609..c16a16c 100644
> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -37,7 +37,7 @@ config BINFMT_ELF_FDPIC
> It is also possible to run FDPIC ELF binaries on MMU linux also.
>
> config BINFMT_FLAT
> - tristate "Kernel support for flat binaries"
> + bool "Kernel support for flat binaries"
> depends on !MMU
> help
> Support uClinux FLAT format binaries.
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
> index 33764fd..274d723 100644
> --- a/fs/binfmt_flat.c
> +++ b/fs/binfmt_flat.c
> @@ -933,14 +933,8 @@ static int __init init_flat_binfmt(void)
> return register_binfmt(&flat_format);
> }
>
> -static void __exit exit_flat_binfmt(void)
> -{
> - unregister_binfmt(&flat_format);
> -}
> -
> /****************************************************************************/
>
> core_initcall(init_flat_binfmt);
> -module_exit(exit_flat_binfmt);
>
> /****************************************************************************/
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>