2023-08-03 14:35:21

by Eugen Hristev

Subject: Re: [PATCH v8 2/8] drm/mediatevk: Add crtc path enum for all_drm_priv array

On 8/2/23 17:47, Jason-JH.Lin wrote:
> Add mtk_drm_crtc_path enum for eatch display path.

Typo: each

>
> Instead of using array index of all_drm_priv in mtk_drm_kms_init(),
> mtk_drm_crtc_path enum can make more readable.

can make *code* more readable ?
>
> Signed-off-by: Jason-JH.Lin <[email protected]>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++---
> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 8 +++++++-
> 2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 249c9fd6347e..89a38561ba27 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -465,21 +465,21 @@ static int mtk_drm_kms_init(struct drm_device *drm)
> for (j = 0; j < private->data->mmsys_dev_num; j++) {
> priv_n = private->all_drm_private[j];
>
> - if (i == 0 && priv_n->data->main_len) {
> + if (i == CRTC_MAIN && priv_n->data->main_len) {
> ret = mtk_drm_crtc_create(drm, priv_n->data->main_path,
> priv_n->data->main_len, j);
> if (ret)
> goto err_component_unbind;
>
> continue;
> - } else if (i == 1 && priv_n->data->ext_len) {
> + } else if (i == CRTC_EXT && priv_n->data->ext_len) {
> ret = mtk_drm_crtc_create(drm, priv_n->data->ext_path,
> priv_n->data->ext_len, j);
> if (ret)
> goto err_component_unbind;
>
> continue;
> - } else if (i == 2 && priv_n->data->third_len) {
> + } else if (i == CRTC_THIRD && priv_n->data->third_len) {
> ret = mtk_drm_crtc_create(drm, priv_n->data->third_path,
> priv_n->data->third_len, j);
> if (ret)
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
> index eb2fd45941f0..f4de8bb27685 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
> @@ -9,11 +9,17 @@
> #include <linux/io.h>
> #include "mtk_drm_ddp_comp.h"
>
> -#define MAX_CRTC 3
> #define MAX_CONNECTOR 2
> #define DDP_COMPONENT_DRM_OVL_ADAPTOR (DDP_COMPONENT_ID_MAX + 1)
> #define DDP_COMPONENT_DRM_ID_MAX (DDP_COMPONENT_DRM_OVL_ADAPTOR + 1)
>
> +enum mtk_drm_crtc_path {
> + CRTC_MAIN,
> + CRTC_EXT,
> + CRTC_THIRD,
> + MAX_CRTC,
> +};
> +
> struct device;
> struct device_node;
> struct drm_crtc;

2023-08-05 07:52:25

by Jason-JH.Lin

Subject: Re: [PATCH v8 2/8] drm/mediatevk: Add crtc path enum for all_drm_priv array

Hi Eugen,

Thanks for the reviews.

On Thu, 2023-08-03 at 16:18 +0300, Eugen Hristev wrote:
> >

> On 8/2/23 17:47, Jason-JH.Lin wrote:
> > Add mtk_drm_crtc_path enum for eatch display path.
>
> Typo: each
>
I'll fix it.

> >
> > Instead of using array index of all_drm_priv in mtk_drm_kms_init(),
> > mtk_drm_crtc_path enum can make more readable.
>
> can make *code* more readable ?

Yes, I'll correct it at the next version.
Thanks.

Regards,
Jason-JH.Lin

> > Signed-off-by: Jason-JH.Lin <[email protected]>
> > ---