2009-09-22 07:17:09

by Luming Yu

[permalink] [raw]
Subject: [RFC PATCH] delete unnecessary BUG_ON !policy->cur

Hi there,

When testing upstream Git tree, there is a BUG_ON hit on a IA64 system
with RHEL 5 user space installed.
Please review the patch below, If make sense, please apply.

Ps. The patch is enclosed in attachment. The inlined one
is c&p of it for reading.


Thanks,
Luming

Signed-off-by: Yu Luming <[email protected]>

cpufreq_userspace.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq_userspace.c
b/drivers/cpufreq/cpufreq_userspace.c
index 66d2d1d..63bd232 100644
--- a/drivers/cpufreq/cpufreq_userspace.c
+++ b/drivers/cpufreq/cpufreq_userspace.c
@@ -119,7 +119,6 @@ static int cpufreq_governor_userspace(st
case CPUFREQ_GOV_START:
if (!cpu_online(cpu))
return -EINVAL;
- BUG_ON(!policy->cur);
mutex_lock(&userspace_mutex);

if (cpus_using_userspace_governor == 0) {


2009-09-22 07:18:28

by Luming Yu

[permalink] [raw]
Subject: Re: [RFC PATCH] delete unnecessary BUG_ON !policy->cur

Patch attached!

On Tue, Sep 22, 2009 at 3:17 PM, Luming Yu <[email protected]> wrote:
> Hi there,
>
> When testing upstream Git tree, there is a BUG_ON hit on a IA64 system
> with RHEL 5 user space installed.
> Please review the patch below, If make sense, please apply.
>
> Ps. The patch is enclosed in attachment. The inlined one
> is c&p of it for reading.
>
>
> Thanks,
> Luming
>
> Signed-off-by: Yu Luming <[email protected]>
>
>  cpufreq_userspace.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_userspace.c
> b/drivers/cpufreq/cpufreq_userspace.c
> index 66d2d1d..63bd232 100644
> --- a/drivers/cpufreq/cpufreq_userspace.c
> +++ b/drivers/cpufreq/cpufreq_userspace.c
> @@ -119,7 +119,6 @@ static int cpufreq_governor_userspace(st
>        case CPUFREQ_GOV_START:
>                if (!cpu_online(cpu))
>                        return -EINVAL;
> -               BUG_ON(!policy->cur);
>                mutex_lock(&userspace_mutex);
>
>                if (cpus_using_userspace_governor == 0) {
>


Attachments:
10.patch (438.00 B)