2016-11-22 15:50:09

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] [media] v4l: vsp1: Fix format-info documentation

Hi Kieran,

Thank you for the patch.

On Thursday 09 Jun 2016 18:57:02 Kieran Bingham wrote:
> Minor tweaks to document the swap register and make the documentation
> match the struct ordering
>
> Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

and applied to my tree.

> ---
> drivers/media/platform/vsp1/vsp1_pipe.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_pipe.h
> b/drivers/media/platform/vsp1/vsp1_pipe.h index 7b56113511dd..6ee3db1fab55
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_pipe.h
> +++ b/drivers/media/platform/vsp1/vsp1_pipe.h
> @@ -25,11 +25,12 @@ struct vsp1_rwpf;
>
> /*
> * struct vsp1_format_info - VSP1 video format description
> - * @mbus: media bus format code
> * @fourcc: V4L2 pixel format FCC identifier
> + * @mbus: media bus format code
> + * @hwfmt: VSP1 hardware format
> + * @swap: swap register control
> * @planes: number of planes
> * @bpp: bits per pixel
> - * @hwfmt: VSP1 hardware format
> * @swap_yc: the Y and C components are swapped (Y comes before C)
> * @swap_uv: the U and V components are swapped (V comes before U)
> * @hsub: horizontal subsampling factor

--
Regards,

Laurent Pinchart