On 07.03.2022 13:18, Krzysztof Kozlowski wrote:
> On 07/03/2022 11:04, Codrin Ciubotariu wrote:
>> +description:
>> + The Microchip Pulse Density Microphone Controller (PDMC) interfaces up to 4 digital microphones
>> + having Pulse Density Modulated (PDM) outputs.
>
> This exceeds 80 characters.
I thought it was raised to 100. checkpatch doesn't report anything also.
>> + microchip,mic-pos:
>> + description: |
>> + Position of PDM microphones on the DS line and the sampling edge (rising or falling) of the
>> + CLK line. A microphone is represented as a pair of DS line and the sampling edge. The first
>> + microphone is mapped to channel 0, the second to channel 1, etc.
>
> This is also too long, wrap at 80.
ok...
>> + pdmc: sound@e1608000 {
>> + compatible = "microchip,sama7g5-pdmc";
>> + #sound-dai-cells = <0>;
>> + reg = <0xe1608000 0x4000>;
>
> In DTS sources: compatible then reg. I mentioned it in previous version.
right, forgot about reg, sorry.
> Best regards,
> Krzysztof
Will send v3, thanks again for your review.
Best regards,
Codrin
On 07/03/2022 12:34, [email protected] wrote:
> On 07.03.2022 13:18, Krzysztof Kozlowski wrote:
>> On 07/03/2022 11:04, Codrin Ciubotariu wrote:
>>> +description:
>>> + The Microchip Pulse Density Microphone Controller (PDMC) interfaces up to 4 digital microphones
>>> + having Pulse Density Modulated (PDM) outputs.
>>
>> This exceeds 80 characters.
>
> I thought it was raised to 100. checkpatch doesn't report anything also.
https://elixir.bootlin.com/linux/v5.17-rc7/source/Documentation/process/coding-style.rst#L104
The hard-constraint was lifted, but still 80 is preferred, unless
readability is increased with 100. That's not the case - readability is
the same, so keep 80.
Best regards,
Krzysztof