2023-04-28 08:19:19

by Peter Rosin

Subject: [PATCH] ARM: dts: at91: tse850: add properties for gpio-line-names

Signal names are one-to-one copies from the schematics, except VBUS
which is an unnamed signal there.

Signed-off-by: Peter Rosin <[email protected]>
---
arch/arm/boot/dts/at91-tse850-3.dts | 60 +++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)

diff --git a/arch/arm/boot/dts/at91-tse850-3.dts b/arch/arm/boot/dts/at91-tse850-3.dts
index b99a4fb44a36..13d92797ada6 100644
--- a/arch/arm/boot/dts/at91-tse850-3.dts
+++ b/arch/arm/boot/dts/at91-tse850-3.dts
@@ -300,3 +300,63 @@

dmas = <0>, <0>; /* Do not use DMA for dbgu */
};
+
+&pioA {
+ gpio-line-names =
+/* 0 */ "SUP-A", "SUP-B", "SUP-C", "SIG<LEV",
+/* 4 */ "", "/RFRST", "", "",
+/* 8 */ "/ADD", "", "/LOOP1", "/LOOP2",
+/* 12 */ "", "", "", "",
+/* 16 */ "LED1GREEN", "LED1RED", "LED2GREEN", "LED2RED",
+/* 20 */ "LED3GREEN", "LED3RED", "LED4GREEN", "LED4RED",
+/* 24 */ "", "", "", "",
+/* 28 */ "", "", "SDA", "SCL";
+};
+
+&pioB {
+ gpio-line-names =
+/* 0 */ "", "", "", "",
+/* 4 */ "", "", "", "",
+/* 8 */ "", "", "", "",
+/* 12 */ "", "", "", "",
+/* 16 */ "", "", "", "",
+/* 20 */ "", "", "", "",
+/* 24 */ "", "", "SIG<LIN", "SIG>LIN",
+/* 28 */ "RXD", "TXD", "BRX", "BTX";
+};
+
+&pioC {
+ gpio-line-names =
+/* 0 */ "ETX0", "ETX1", "ERX0", "ERX1",
+/* 4 */ "ETXEN", "ECRSDV", "ERXER", "EREFCK",
+/* 8 */ "EMDC", "EMDIO", "", "",
+/* 12 */ "", "", "", "/ILIM",
+/* 16 */ "BCK", "LRCK", "DIN", "",
+/* 20 */ "", "", "", "",
+/* 24 */ "", "", "", "",
+/* 28 */ "", "", "", "VBUS";
+};
+
+&pioD {
+ gpio-line-names =
+/* 0 */ "I1", "I2", "O1", "EXTVEN",
+/* 4 */ "", "456KHZ", "VCTRL", "SYNCSEL",
+/* 8 */ "STEREO", "", "", "",
+/* 12 */ "", "", "", "",
+/* 16 */ "", ">LIN", "LIN>", "",
+/* 20 */ "VREFEN", "", "", "",
+/* 24 */ "", "", "VINOK", "",
+/* 28 */ "POEOK", "USBON", "POELOAD", "";
+};
+
+&pioE {
+ gpio-line-names =
+/* 0 */ "", "", "", "",
+/* 4 */ "", "", "", "",
+/* 8 */ "", "", "", "",
+/* 12 */ "", "", "", "",
+/* 16 */ "", "", "", "",
+/* 20 */ "", "ALE", "CLE", "",
+/* 24 */ "", "", "", "",
+/* 28 */ "", "", "", "/ETHINT";
+};
--
2.20.1

2023-05-22 09:51:37

by Claudiu Beznea

Subject: Re: [PATCH] ARM: dts: at91: tse850: add properties for gpio-line-names

On 28.04.2023 11:06, Peter Rosin wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Signal names are one-to-one copies from the schematics, except VBUS
> which is an unnamed signal there.
>
> Signed-off-by: Peter Rosin <[email protected]>

Applied to at91-dt, thanks!

Please note that I've added 1 tab in front of index based comment. It looks
more readable this way and this is how other DTSes I've inspect are doing.
Please have a look [1] and let me know if there are any issues.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git/commit/?h=at91-dt&id=08e4dd1d12acc02244b119790c8e50bbf3618a89

> ---
> arch/arm/boot/dts/at91-tse850-3.dts | 60 +++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91-tse850-3.dts b/arch/arm/boot/dts/at91-tse850-3.dts
> index b99a4fb44a36..13d92797ada6 100644
> --- a/arch/arm/boot/dts/at91-tse850-3.dts
> +++ b/arch/arm/boot/dts/at91-tse850-3.dts
> @@ -300,3 +300,63 @@
>
> dmas = <0>, <0>; /* Do not use DMA for dbgu */
> };
> +
> +&pioA {
> + gpio-line-names =
> +/* 0 */ "SUP-A", "SUP-B", "SUP-C", "SIG<LEV",
> +/* 4 */ "", "/RFRST", "", "",
> +/* 8 */ "/ADD", "", "/LOOP1", "/LOOP2",
> +/* 12 */ "", "", "", "",
> +/* 16 */ "LED1GREEN", "LED1RED", "LED2GREEN", "LED2RED",
> +/* 20 */ "LED3GREEN", "LED3RED", "LED4GREEN", "LED4RED",
> +/* 24 */ "", "", "", "",
> +/* 28 */ "", "", "SDA", "SCL";
> +};
> +
> +&pioB {
> + gpio-line-names =
> +/* 0 */ "", "", "", "",
> +/* 4 */ "", "", "", "",
> +/* 8 */ "", "", "", "",
> +/* 12 */ "", "", "", "",
> +/* 16 */ "", "", "", "",
> +/* 20 */ "", "", "", "",
> +/* 24 */ "", "", "SIG<LIN", "SIG>LIN",
> +/* 28 */ "RXD", "TXD", "BRX", "BTX";
> +};
> +
> +&pioC {
> + gpio-line-names =
> +/* 0 */ "ETX0", "ETX1", "ERX0", "ERX1",
> +/* 4 */ "ETXEN", "ECRSDV", "ERXER", "EREFCK",
> +/* 8 */ "EMDC", "EMDIO", "", "",
> +/* 12 */ "", "", "", "/ILIM",
> +/* 16 */ "BCK", "LRCK", "DIN", "",
> +/* 20 */ "", "", "", "",
> +/* 24 */ "", "", "", "",
> +/* 28 */ "", "", "", "VBUS";
> +};
> +
> +&pioD {
> + gpio-line-names =
> +/* 0 */ "I1", "I2", "O1", "EXTVEN",
> +/* 4 */ "", "456KHZ", "VCTRL", "SYNCSEL",
> +/* 8 */ "STEREO", "", "", "",
> +/* 12 */ "", "", "", "",
> +/* 16 */ "", ">LIN", "LIN>", "",
> +/* 20 */ "VREFEN", "", "", "",
> +/* 24 */ "", "", "VINOK", "",
> +/* 28 */ "POEOK", "USBON", "POELOAD", "";
> +};
> +
> +&pioE {
> + gpio-line-names =
> +/* 0 */ "", "", "", "",
> +/* 4 */ "", "", "", "",
> +/* 8 */ "", "", "", "",
> +/* 12 */ "", "", "", "",
> +/* 16 */ "", "", "", "",
> +/* 20 */ "", "ALE", "CLE", "",
> +/* 24 */ "", "", "", "",
> +/* 28 */ "", "", "", "/ETHINT";
> +};
> --
> 2.20.1
>

2023-05-22 10:28:25

by Peter Rosin

Subject: Re: [PATCH] ARM: dts: at91: tse850: add properties for gpio-line-names

Hi!

2023-05-22 at 11:46, [email protected] wrote:
> On 28.04.2023 11:06, Peter Rosin wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Signal names are one-to-one copies from the schematics, except VBUS
>> which is an unnamed signal there.
>>
>> Signed-off-by: Peter Rosin <[email protected]>
>
> Applied to at91-dt, thanks!
>
> Please note that I've added 1 tab in front of index based comment. It looks
> more readable this way and this is how other DTSes I've inspect are doing.
> Please have a look [1] and let me know if there are any issues.
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git/commit/?h=at91-dt&id=08e4dd1d12acc02244b119790c8e50bbf3618a89

Looks mighty fine to me, please go ahead.

Cheers,
Peter