2022-08-03 02:04:42

by Jianhua Lu

Subject: [PATCH v1] pinctrl: qcom: sm8250: Fix PDC map

Fix the PDC mapping for SM8250, gpio39 is mapped to irq73(not irq37).

Fixes: b41efeed507a("pinctrl: qcom: sm8250: Specify PDC map.")
Signed-off-by: Jianhua Lu <[email protected]>
---

Changes in v1:
- fixes typo error(mapped target is irq, not gpio).

drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
index af144e724bd9..3bd7f9fedcc3 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
@@ -1316,7 +1316,7 @@ static const struct msm_pingroup sm8250_groups[] = {
static const struct msm_gpio_wakeirq_map sm8250_pdc_map[] = {
{ 0, 79 }, { 1, 84 }, { 2, 80 }, { 3, 82 }, { 4, 107 }, { 7, 43 },
{ 11, 42 }, { 14, 44 }, { 15, 52 }, { 19, 67 }, { 23, 68 }, { 24, 105 },
- { 27, 92 }, { 28, 106 }, { 31, 69 }, { 35, 70 }, { 39, 37 },
+ { 27, 92 }, { 28, 106 }, { 31, 69 }, { 35, 70 }, { 39, 73 },
{ 40, 108 }, { 43, 71 }, { 45, 72 }, { 47, 83 }, { 51, 74 }, { 55, 77 },
{ 59, 78 }, { 63, 75 }, { 64, 81 }, { 65, 87 }, { 66, 88 }, { 67, 89 },
{ 68, 54 }, { 70, 85 }, { 77, 46 }, { 80, 90 }, { 81, 91 }, { 83, 97 },
--
2.35.1

2022-08-03 15:56:51

by Konrad Dybcio

Subject: Re: [PATCH v1] pinctrl: qcom: sm8250: Fix PDC map

On 3.08.2022 03:56, Jianhua Lu wrote:
> Fix the PDC mapping for SM8250, gpio39 is mapped to irq73(not irq37).
>
> Fixes: b41efeed507a("pinctrl: qcom: sm8250: Specify PDC map.")
> Signed-off-by: Jianhua Lu <[email protected]>
> ---
>
> Changes in v1:
Acutally, it should be v2 as the first send is assumed to be a v1.
> - fixes typo error(mapped target is irq, not gpio).
>

The change looks in line with msm-4.19 though.

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> index af144e724bd9..3bd7f9fedcc3 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
> @@ -1316,7 +1316,7 @@ static const struct msm_pingroup sm8250_groups[] = {
> static const struct msm_gpio_wakeirq_map sm8250_pdc_map[] = {
> { 0, 79 }, { 1, 84 }, { 2, 80 }, { 3, 82 }, { 4, 107 }, { 7, 43 },
> { 11, 42 }, { 14, 44 }, { 15, 52 }, { 19, 67 }, { 23, 68 }, { 24, 105 },
> - { 27, 92 }, { 28, 106 }, { 31, 69 }, { 35, 70 }, { 39, 37 },
> + { 27, 92 }, { 28, 106 }, { 31, 69 }, { 35, 70 }, { 39, 73 },
> { 40, 108 }, { 43, 71 }, { 45, 72 }, { 47, 83 }, { 51, 74 }, { 55, 77 },
> { 59, 78 }, { 63, 75 }, { 64, 81 }, { 65, 87 }, { 66, 88 }, { 67, 89 },
> { 68, 54 }, { 70, 85 }, { 77, 46 }, { 80, 90 }, { 81, 91 }, { 83, 97 },

2022-08-03 18:48:35

by Linus Walleij

Subject: Re: [PATCH v1] pinctrl: qcom: sm8250: Fix PDC map

On Wed, Aug 3, 2022 at 3:57 AM Jianhua Lu <[email protected]> wrote:

> Fix the PDC mapping for SM8250, gpio39 is mapped to irq73(not irq37).
>
> Fixes: b41efeed507a("pinctrl: qcom: sm8250: Specify PDC map.")
> Signed-off-by: Jianhua Lu <[email protected]>
> ---
>
> Changes in v1:
> - fixes typo error(mapped target is irq, not gpio).

This v2 version named v1 applied!

Thanks for a quick fixup.

Yours,
Linus Walleij