2019-03-20 14:17:25

by Yue Haibing

Subject: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static

From: YueHaibing <[email protected]>

Fix sparse warning:

drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
symbol 'pinctrl_ipc_handle' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/pinctrl/freescale/pinctrl-scu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
index 83e69c0..73bf1d9 100644
--- a/drivers/pinctrl/freescale/pinctrl-scu.c
+++ b/drivers/pinctrl/freescale/pinctrl-scu.c
@@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get {
u32 val;
} __packed;

-struct imx_sc_ipc *pinctrl_ipc_handle;
+static struct imx_sc_ipc *pinctrl_ipc_handle;

int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
{
--
2.7.0

2019-03-20 20:01:05

by Mukesh Ojha

Subject: Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static

On 3/20/2019 7:44 PM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
> symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/pinctrl/freescale/pinctrl-scu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
> index 83e69c0..73bf1d9 100644
> --- a/drivers/pinctrl/freescale/pinctrl-scu.c
> +++ b/drivers/pinctrl/freescale/pinctrl-scu.c
> @@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get {
> u32 val;
> } __packed;
>
> -struct imx_sc_ipc *pinctrl_ipc_handle;
> +static struct imx_sc_ipc *pinctrl_ipc_handle;
>
> int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
> {


Reviewed-by: Mukesh Ojha <[email protected]>

2019-04-04 05:18:16

by Linus Walleij

Subject: Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static

On Wed, Mar 20, 2019 at 9:15 PM Yue Haibing <[email protected]> wrote:

> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
> symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Patch applied.

Yours,
Linus Walleij