2020-02-12 02:36:19

by Sam Shih

Subject: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support

This adds pwm support for MT7629.
Used:
https://patchwork.kernel.org/patch/11160851/

Change since v1:
remove unused property num-pwm

Signed-off-by: Sam Shih <[email protected]>
---
arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
index 867b88103b9d..ce2a30a24017 100644
--- a/arch/arm/boot/dts/mt7629.dtsi
+++ b/arch/arm/boot/dts/mt7629.dtsi
@@ -241,6 +241,20 @@
status = "disabled";
};

+ pwm: pwm@11006000 {
+ compatible = "mediatek,mt7629-pwm";
+ reg = <0x11006000 0x1000>;
+ interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
+ clocks = <&topckgen CLK_TOP_PWM_SEL>,
+ <&pericfg CLK_PERI_PWM_PD>,
+ <&pericfg CLK_PERI_PWM1_PD>;
+ clock-names = "top", "main", "pwm1";
+ assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
+ assigned-clock-parents =
+ <&topckgen CLK_TOP_UNIVPLL2_D4>;
+ status = "disabled";
+ };
+
i2c: i2c@11007000 {
compatible = "mediatek,mt7629-i2c",
"mediatek,mt2712-i2c";
--
2.17.1

2020-02-12 11:10:34

by Matthias Brugger

Subject: Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support

On 12/02/2020 03:35, Sam Shih wrote:
> This adds pwm support for MT7629.

The information below should not be part of the commit message, the next time
please put it below the line "---".

> Used:
> https://patchwork.kernel.org/patch/11160851/
>
> Change since v1:
> remove unused property num-pwm
>
> Signed-off-by: Sam Shih <[email protected]>
> ---
> arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 867b88103b9d..ce2a30a24017 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -241,6 +241,20 @@
> status = "disabled";
> };
>
> + pwm: pwm@11006000 {
> + compatible = "mediatek,mt7629-pwm";
> + reg = <0x11006000 0x1000>;
> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> + <&pericfg CLK_PERI_PWM_PD>,
> + <&pericfg CLK_PERI_PWM1_PD>;
> + clock-names = "top", "main", "pwm1";
> + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> + assigned-clock-parents =
> + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> + status = "disabled";
> + };
> +

This does not match the binding description.
Please fix that.


> i2c: i2c@11007000 {
> compatible = "mediatek,mt7629-i2c",
> "mediatek,mt2712-i2c";
>

2020-05-16 15:41:14

by Matthias Brugger

Subject: Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support

On 12/02/2020 03:35, Sam Shih wrote:
> This adds pwm support for MT7629.
> Used:
> https://patchwork.kernel.org/patch/11160851/
>
> Change since v1:
> remove unused property num-pwm
>
> Signed-off-by: Sam Shih <[email protected]>

Applied now to v5.7-next/dts32

Thanks!

> ---
> arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 867b88103b9d..ce2a30a24017 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -241,6 +241,20 @@
> status = "disabled";
> };
>
> + pwm: pwm@11006000 {
> + compatible = "mediatek,mt7629-pwm";
> + reg = <0x11006000 0x1000>;
> + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&topckgen CLK_TOP_PWM_SEL>,
> + <&pericfg CLK_PERI_PWM_PD>,
> + <&pericfg CLK_PERI_PWM1_PD>;
> + clock-names = "top", "main", "pwm1";
> + assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> + assigned-clock-parents =
> + <&topckgen CLK_TOP_UNIVPLL2_D4>;
> + status = "disabled";
> + };
> +
> i2c: i2c@11007000 {
> compatible = "mediatek,mt7629-i2c",
> "mediatek,mt2712-i2c";
>