2016-10-19 22:54:07

by Laura Abbott

Subject: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq

When converting to a shared library in ac5a181d065d ("cpupower: Add
cpuidle parts into library"), cpu_freq_cpu_exists was converted to
cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
-ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
Check for the correct return value in cpufreq-set.

See https://bugzilla.redhat.com/show_bug.cgi?id=1374212

Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Reported-by: Julian Seward <[email protected]>
Signed-off-by: Laura Abbott <[email protected]>
---
v2: Drop another redundant cpupower_is_cpu_online

Resend because I've heard nothing about this patch and it's still broken
as far as I can tell.
---
tools/power/cpupower/utils/cpufreq-set.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c
index b4bf769..1eef0ae 100644
--- a/tools/power/cpupower/utils/cpufreq-set.c
+++ b/tools/power/cpupower/utils/cpufreq-set.c
@@ -296,7 +296,7 @@ int cmd_freq_set(int argc, char **argv)
struct cpufreq_affected_cpus *cpus;

if (!bitmask_isbitset(cpus_chosen, cpu) ||
- cpupower_is_cpu_online(cpu))
+ cpupower_is_cpu_online(cpu) != 1)
continue;

cpus = cpufreq_get_related_cpus(cpu);
@@ -316,10 +316,7 @@ int cmd_freq_set(int argc, char **argv)
cpu <= bitmask_last(cpus_chosen); cpu++) {

if (!bitmask_isbitset(cpus_chosen, cpu) ||
- cpupower_is_cpu_online(cpu))
- continue;
-
- if (cpupower_is_cpu_online(cpu) != 1)
+ cpupower_is_cpu_online(cpu) != 1)
continue;

printf(_("Setting cpu: %d\n"), cpu);
--
2.7.4

2016-10-20 08:13:04

by Shilpasri G Bhat

Subject: Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq

On 10/20/2016 04:23 AM, Laura Abbott wrote:
> When converting to a shared library in ac5a181d065d ("cpupower: Add
> cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> Check for the correct return value in cpufreq-set.
>
> See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
>
> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> Reported-by: Julian Seward <[email protected]>
> Signed-off-by: Laura Abbott <[email protected]>
> ---
> v2: Drop another redundant cpupower_is_cpu_online

Reviewed-by:Shilpasri G Bhat <[email protected]>

2016-10-24 15:11:36

by Thomas Renninger

Subject: Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq

On Thursday, October 20, 2016 01:42:49 PM Shilpasri G Bhat wrote:
> On 10/20/2016 04:23 AM, Laura Abbott wrote:
> > When converting to a shared library in ac5a181d065d ("cpupower: Add
> > cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> > cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> > -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> > Check for the correct return value in cpufreq-set.
> >
> > See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
> >
> > Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> > Reported-by: Julian Seward <[email protected]>
> > Signed-off-by: Laura Abbott <[email protected]>
> > ---
> > v2: Drop another redundant cpupower_is_cpu_online
>
> Reviewed-by:Shilpasri G Bhat <[email protected]>

Acked-by: Thomas Renninger <[email protected]>

I wanted to go through all recently sent patches and adjust rebase them to
my lates changes.
But I guess the fact that I push this from day to day because of other
stuff should not hold off such important fixes.

I collect and review all others as well the next day(s)..

Thomas