2022-09-29 14:59:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 01/30] dt-bindings: riscv: Add StarFive JH7110 bindings

On 29/09/2022 16:31, Hal Feng wrote:
> From: Emil Renner Berthing <[email protected]>

Drop last "bindings" from subject, it's redundant.

>
> Add device tree bindings for the StarFive JH7110 RISC-V SoC and the
> VisionFive2 board for it.
>
> Signed-off-by: Emil Renner Berthing <[email protected]>
> Signed-off-by: Hal Feng <[email protected]>
> ---
> Documentation/devicetree/bindings/riscv/starfive.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> index 5b36243fd674..543be573921d 100644
> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> @@ -21,6 +21,9 @@ properties:
> - items:
> - const: beagle,beaglev-starlight-jh7100-r0
> - const: starfive,jh7100

Blank line.

> + - items:
> + - const: starfive,visionfive-v2
> + - const: starfive,jh7110
>
> additionalProperties: true
>

Best regards,
Krzysztof


2022-10-08 05:24:01

by Hal Feng

[permalink] [raw]
Subject: Re: [PATCH v1 01/30] dt-bindings: riscv: Add StarFive JH7110 bindings

On Thu, 29 Sep 2022 16:34:22 +0200, Krzysztof Kozlowski wrote:
> On 29/09/2022 16:31, Hal Feng wrote:
> > From: Emil Renner Berthing <[email protected]>
>
> Drop last "bindings" from subject, it's redundant.

Will fix. Thanks.

>
> >
> > Add device tree bindings for the StarFive JH7110 RISC-V SoC and the
> > VisionFive2 board for it.
> >
> > Signed-off-by: Emil Renner Berthing <[email protected]>
> > Signed-off-by: Hal Feng <[email protected]>
> > ---
> > Documentation/devicetree/bindings/riscv/starfive.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > index 5b36243fd674..543be573921d 100644
> > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> > @@ -21,6 +21,9 @@ properties:
> > - items:
> > - const: beagle,beaglev-starlight-jh7100-r0
> > - const: starfive,jh7100
>
> Blank line.

Will fix. Thanks.

Best Regards,
Hal