2019-03-13 23:17:27

by Jaegeuk Kim

Subject: [PATCH] f2fs: set pin_file under CAP_SYS_ADMIN

Android uses pin_file for uncrypt during OTA, and that should be managed by
CAP_SYS_ADMIN only.

Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 807a97ad2430..012815d816e6 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2873,8 +2873,8 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg)
__u32 pin;
int ret = 0;

- if (!inode_owner_or_capable(inode))
- return -EACCES;
+ if (!capable(CAP_SYS_ADMIN))
+ return -EPERM;

if (get_user(pin, (__u32 __user *)arg))
return -EFAULT;
--
2.19.0.605.g01d371f741-goog

2019-03-14 14:37:18

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: set pin_file under CAP_SYS_ADMIN

On 2019-3-14 7:16, Jaegeuk Kim wrote:
> Android uses pin_file for uncrypt during OTA, and that should be managed by
> CAP_SYS_ADMIN only.
>
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,