2021-03-24 10:00:48

by Hermes Zhang

[permalink] [raw]
Subject: RE: [PATCH v3] dt-binding: leds: Document leds-multi-gpio bindings

> >
> > Notes:
> > Add maxItems
>
> What about the other part of the series? I think you should send both
> patches together with an introduction message on both. If you only change
> one patch for a new version spin of the series, just send the other one
> unchanged.
>
> (It makes no sense to merge the binding as long as the driver is not merged,
> otherwise you would end up with a binding without driver. So keeping them
> together should help reviewers and maintainers.)
>

Hi Alexander,

The other part is here: https://lore.kernel.org/patchwork/patch/1399875/, so do you mean I need to combine these two as one commit? Or is there anyway to link them together? Thanks.

I'm first time to commit a new driver, sorry for that.

Best Regards,
Hermes


2021-03-24 10:06:19

by Alexander Dahl

[permalink] [raw]
Subject: RE: [PATCH v3] dt-binding: leds: Document leds-multi-gpio bindings

Hello,

> Hermes Zhang <[email protected]> hat am 24.03.2021 07:04 geschrieben:
>
>
> > >
> > > Notes:
> > > Add maxItems
> >
> > What about the other part of the series? I think you should send both
> > patches together with an introduction message on both. If you only change
> > one patch for a new version spin of the series, just send the other one
> > unchanged.
> >
> > (It makes no sense to merge the binding as long as the driver is not merged,
> > otherwise you would end up with a binding without driver. So keeping them
> > together should help reviewers and maintainers.)
> >
>
> Hi Alexander,
>
> The other part is here: https://lore.kernel.org/patchwork/patch/1399875/, so do you mean I need to combine these two as one commit? Or is there anyway to link them together? Thanks.

Two commits.

For sending more than one patch in a series call `git format-patch` with the option --cover-letter. Please have a look at documentation on `git format-patch` and `git send-email` again.

You can see how it looks if you look out for other patch series on the from the past, especially those with subjects like "[PATCH 0/x] ...". An e-mail client supporting threaded view helps a lot.

> I'm first time to commit a new driver, sorry for that.

Thanks for trying. No need to be sorry, the tools are hard and expectations are high. In the end it's all about efficiency.

Have a nice day
Alex