2019-09-26 10:59:49

by Yunfeng Ye

Subject: [PATCH] async: Using current_work() to implement current_is_async()

current_is_async() can be implemented using current_work(), it's better
not to be aware of the workqueue's internal information.

Signed-off-by: Yunfeng Ye <[email protected]>
---
kernel/async.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/async.c b/kernel/async.c
index 1de270d..a849f98 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -53,8 +53,6 @@ asynchronous and synchronous parts of the kernel.
#include <linux/slab.h>
#include <linux/workqueue.h>

-#include "workqueue_internal.h"
-
static async_cookie_t next_cookie = 1;

#define MAX_WORK 32768
@@ -327,8 +325,8 @@ EXPORT_SYMBOL_GPL(async_synchronize_cookie);
*/
bool current_is_async(void)
{
- struct worker *worker = current_wq_worker();
+ struct work_struct *work = current_work();

- return worker && worker->current_func == async_run_entry_fn;
+ return work && work->func == async_run_entry_fn;
}
EXPORT_SYMBOL_GPL(current_is_async);
--
2.7.4

2019-09-26 15:31:39

by Bart Van Assche

Subject: Re: [PATCH] async: Using current_work() to implement current_is_async()

On 9/26/19 1:40 AM, Yunfeng Ye wrote:
> current_is_async() can be implemented using current_work(), it's better
> not to be aware of the workqueue's internal information.

Reviewed-by: Bart Van Assche <[email protected]>

2019-09-27 01:05:58

by Yunfeng Ye

Subject: Re: [PATCH] async: Using current_work() to implement current_is_async()

On 2019/9/26 23:27, Bart Van Assche wrote:
> On 9/26/19 1:40 AM, Yunfeng Ye wrote:
>> current_is_async() can be implemented using current_work(), it's better
>> not to be aware of the workqueue's internal information.
>
> Reviewed-by: Bart Van Assche <[email protected]>
>
I will update the patch with Reviewed-by, thanks.
> .
>