2022-04-22 21:07:09

by icenowy

Subject: [PATCH 1/4] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI

From: Icenowy Zheng <[email protected]>

Allwinner R329 SPI has two controllers, and the second one has helper
functions for MIPI-DBI Type C.

Add compatible strings for these controllers

Signed-off-by: Icenowy Zheng <[email protected]>
---
.../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
index ca4c95345a49..6354635241fc 100644
--- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
@@ -21,6 +21,8 @@ properties:
oneOf:
- const: allwinner,sun6i-a31-spi
- const: allwinner,sun8i-h3-spi
+ - const: allwinner,sun50i-r329-spi
+ - const: allwinner,sun50i-r329-spi-dbi
- items:
- enum:
- allwinner,sun8i-r40-spi
--
2.35.1

2022-04-22 23:54:28

by Samuel Holland

Subject: Re: [PATCH 1/4] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI

On 4/22/22 10:56 AM, [email protected] wrote:
> From: Icenowy Zheng <[email protected]>
>
> Allwinner R329 SPI has two controllers, and the second one has helper
> functions for MIPI-DBI Type C.
>
> Add compatible strings for these controllers
>
> Signed-off-by: Icenowy Zheng <[email protected]>
> ---
> .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index ca4c95345a49..6354635241fc 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -21,6 +21,8 @@ properties:
> oneOf:
> - const: allwinner,sun6i-a31-spi
> - const: allwinner,sun8i-h3-spi
> + - const: allwinner,sun50i-r329-spi
> + - const: allwinner,sun50i-r329-spi-dbi

As far as I'm aware, the SPI portion of the DBI controller is
register-compatible with the regular SPI controller. So I would expect using
that as a fallback compatible for the DBI variant.

Regards,
Samuel

> - items:
> - enum:
> - allwinner,sun8i-r40-spi
>

2022-04-23 08:54:46

by Icenowy Zheng

Subject: Re: [PATCH 1/4] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI

在 2022-04-22星期五的 18:49 -0500，Samuel Holland写道：
> On 4/22/22 10:56 AM, [email protected] wrote:
> > From: Icenowy Zheng <[email protected]>
> >
> > Allwinner R329 SPI has two controllers, and the second one has
> > helper
> > functions for MIPI-DBI Type C.
> >
> > Add compatible strings for these controllers
> >
> > Signed-off-by: Icenowy Zheng <[email protected]>
> > ---
> >  .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml        |
> > 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-
> > a31-spi.yaml
> > b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-
> > spi.yaml
> > index ca4c95345a49..6354635241fc 100644
> > --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-
> > spi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-
> > spi.yaml
> > @@ -21,6 +21,8 @@ properties:
> >      oneOf:
> >        - const: allwinner,sun6i-a31-spi
> >        - const: allwinner,sun8i-h3-spi
> > +      - const: allwinner,sun50i-r329-spi
> > +      - const: allwinner,sun50i-r329-spi-dbi
>
> As far as I'm aware, the SPI portion of the DBI controller is
> register-compatible with the regular SPI controller. So I would
> expect using
> that as a fallback compatible for the DBI variant.

This sounds reasonable.

>
> Regards,
> Samuel
>
> >        - items:
> >            - enum:
> >                - allwinner,sun8i-r40-spi
> >
>