2020-01-07 05:44:24

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the tip tree

---

Hi all,

[This has been happening for a while, I just missed it :-( ]

After merging the tip tree, today's linux-next build (x86_64 allnoconfig)
produced this warning:

arch/x86/kernel/unwind_orc.c:210:12: warning: 'orc_sort_cmp' defined but not used [-Wunused-function]
210 | static int orc_sort_cmp(const void *_a, const void *_b)
| ^~~~~~~~~~~~
arch/x86/kernel/unwind_orc.c:190:13: warning: 'orc_sort_swap' defined but not used [-Wunused-function]
190 | static void orc_sort_swap(void *_a, void *_b, int size)
| ^~~~~~~~~~~~~

Introduced by commit

f14bf6a350df ("x86/unwind/orc: Remove boot-time ORC unwind tables sorting")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2020-01-07 07:17:03

by Ingo Molnar

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the tip tree

---

* Stephen Rothwell <[email protected]> wrote:

> Hi all,
>
> [This has been happening for a while, I just missed it :-( ]
>
> After merging the tip tree, today's linux-next build (x86_64 allnoconfig)
> produced this warning:
>
> arch/x86/kernel/unwind_orc.c:210:12: warning: 'orc_sort_cmp' defined but not used [-Wunused-function]
> 210 | static int orc_sort_cmp(const void *_a, const void *_b)
> | ^~~~~~~~~~~~
> arch/x86/kernel/unwind_orc.c:190:13: warning: 'orc_sort_swap' defined but not used [-Wunused-function]
> 190 | static void orc_sort_swap(void *_a, void *_b, int size)
> | ^~~~~~~~~~~~~
>
> Introduced by commit
>
> f14bf6a350df ("x86/unwind/orc: Remove boot-time ORC unwind tables sorting")

Now fixed via:

22a7fa8848c5: ("x86/unwind/orc: Fix !CONFIG_MODULES build warning")

Will push it out after some testing, should go out with the next
tip:auto-latest version.

Thanks,

Ingo

2020-01-07 07:25:00

by Shile Zhang

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the tip tree

---

On 2020/1/7 15:16, Ingo Molnar wrote:
> * Stephen Rothwell <[email protected]> wrote:
>
>> Hi all,
>>
>> [This has been happening for a while, I just missed it :-( ]
>>
>> After merging the tip tree, today's linux-next build (x86_64 allnoconfig)
>> produced this warning:
>>
>> arch/x86/kernel/unwind_orc.c:210:12: warning: 'orc_sort_cmp' defined but not used [-Wunused-function]
>> 210 | static int orc_sort_cmp(const void *_a, const void *_b)
>> | ^~~~~~~~~~~~
>> arch/x86/kernel/unwind_orc.c:190:13: warning: 'orc_sort_swap' defined but not used [-Wunused-function]
>> 190 | static void orc_sort_swap(void *_a, void *_b, int size)
>> | ^~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>> f14bf6a350df ("x86/unwind/orc: Remove boot-time ORC unwind tables sorting")
> Now fixed via:
>
> 22a7fa8848c5: ("x86/unwind/orc: Fix !CONFIG_MODULES build warning")
>
> Will push it out after some testing, should go out with the next
> tip:auto-latest version.
Thanks very much! sorry for trouble.
>
> Thanks,
>
> Ingo