2024-04-18 13:04:15

by Chukun Pan

Subject: [PATCH 2/2] arm64: dts: rockchip: correct the model name for Radxa ROCK 3A

According to https://radxa.com/products/rock3/3a,
the name of this board should be "Radxa ROCK 3A".
Also update compatible to match the model name.

Suggested-by: FUKAUMI Naoki <[email protected]>
Signed-off-by: Chukun Pan <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index c62230308457..e859c075bd46 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -8,8 +8,8 @@
#include "rk3568.dtsi"

/ {
- model = "Radxa ROCK3 Model A";
- compatible = "radxa,rock3a", "rockchip,rk3568";
+ model = "Radxa ROCK 3A";
+ compatible = "radxa,rock-3a", "rockchip,rk3568";

aliases {
ethernet0 = &gmac1;
--
2.25.1

2024-04-18 15:23:22

by Dragan Simic

Subject: Re: [PATCH 2/2] arm64: dts: rockchip: correct the model name for Radxa ROCK 3A

On 2024-04-18 15:01, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
>
> Suggested-by: FUKAUMI Naoki <[email protected]>
> Signed-off-by: Chukun Pan <[email protected]>

Looking good to me.

Reviewed-by: Dragan Simic <[email protected]>

> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index c62230308457..e859c075bd46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -8,8 +8,8 @@
> #include "rk3568.dtsi"
>
> / {
> - model = "Radxa ROCK3 Model A";
> - compatible = "radxa,rock3a", "rockchip,rk3568";
> + model = "Radxa ROCK 3A";
> + compatible = "radxa,rock-3a", "rockchip,rk3568";
>
> aliases {
> ethernet0 = &gmac1;