2000-11-24 21:37:43

by David Riley

[permalink] [raw]
Subject: asm-ppc/elf.h error

--- linux/include/asm-ppc/elf.h.old Fri Nov 24 15:42:44 2000
+++ linux/include/asm-ppc/elf.h Fri Nov 24 15:43:54 2000
@@ -4,6 +4,7 @@
/*
* ELF register definitions..
*/
+#include <linux/config.h>
#include <asm/ptrace.h>

#define ELF_NGREG 48 /* includes nip, msr, lr, etc. */
@@ -25,9 +26,11 @@
typedef double elf_fpreg_t;
typedef elf_fpreg_t elf_fpregset_t[ELF_NFPREG];

+#ifdef CONFIG_ALTIVEC
/* Altivec registers */
typedef __vector128 elf_vrreg_t;
typedef elf_vrreg_t elf_vrregset_t[ELF_NVRREG];
+#endif

#ifdef __KERNEL__


Attachments:
elf.h.diff (545.00 B)

2000-11-27 13:10:35

by Franz Sirl

[permalink] [raw]
Subject: Re: asm-ppc/elf.h error

At 22:07 24.11.00, David Riley wrote:
>In asm-ppc/elf.h, <asm/types.h> is not included. This breaks
>compilations of anything that compiles it (e.g. binutils) because the
>vector registers for Altivec aren't defined elsewhere. Included is a
>quick diff. I didn't know which PPC maintainer to send this to, so I
>posted it to the linuxppc-dev list.

(Looking at the correct patch)

Why do you need that? Your claim that binutils needs that is simply wrong,
I compiled CVS binutils without problems against bk 2.4.0-t11. In any case,
glibc-2.1.3 and glibc-2.2 have this stuff in sys/procfs.h, so you should
use that instead I guess. That's at least what gdb uses.

Franz.