Keith Owens wrote:
>
> On Wed, 31 Jan 2001 19:02:03 -0800,
> LA Walsh <[email protected]> wrote:
> >This seems to serialize the delete, run the mod-installs in parallel, then run the
> >depmod when they are done.
>
> It works, until somebody does this
>
> make -j 4 modules modules_install
---
But that doesn't work now.
> There is not, and never has been, any interlock between make modules
> and make modules_install. If you let modules_install run in parallel
> then people will be tempted to issue the incorrect command above
> instead of the required separate commands.
---
>
> make -j 4 modules
> make -j 4 modules_install
>
> You gain a few seconds on module_install but leave more room for user
> error.
---
A bit of documentation at the beginning of the Makefile would do wonders
for kernel-developer (not end user, please!) clarity. I've oft'asked the question
as to what really is supported. I've tried things like make dep bzImage modules --
I noticed it didn't work fairly quickly. Same with modules/modules_install --
people would probably figure that one out, but just a bit of documentation would
help even that.
--
Linda A Walsh | Trust Technology, Core Linux, SGI
[email protected] | Voice: (650) 933-5338
On Thu, 01 Feb 2001 00:13:17 -0800,
LA Walsh <[email protected]> wrote:
>Keith Owens wrote:
>> It works, until somebody does this
>>
>> make -j 4 modules modules_install
>---
> But that doesn't work now.
Agreed, but letting modules_install parallel run increases the risk of
somebody doing that. Most users will think that they can combine two
parallel runs into a single command, but if they are forced to single
thread modules_install it reduces the risk of user error.
> A bit of documentation at the beginning of the Makefile would do wonders
>for kernel-developer (not end user, please!) clarity. I've oft'asked the question
>as to what really is supported. I've tried things like make dep bzImage modules --
>I noticed it didn't work fairly quickly. Same with modules/modules_install --
>people would probably figure that one out, but just a bit of documentation would
>help even that.
The 2.5 kbuild system will be fully documented, all the way from
reasons for doing things down to how they are down. Trust me on this!
I have had too many problems with undocumented changes in kbuild.