2001-02-07 19:28:33

by Dave Jones

[permalink] [raw]
Subject: [PATCH] natsemi pci_enable_device fixup.


And they keep on coming.

d.

--
| Dave Jones. http://www.suse.de/~davej
| SuSE Labs

diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/natsemi.c linux-dj/drivers/net/natsemi.c
--- linux/drivers/net/natsemi.c Wed Feb 7 12:42:40 2001
+++ linux-dj/drivers/net/natsemi.c Wed Feb 7 19:24:02 2001
@@ -380,11 +380,13 @@

find_cnt++;
option = find_cnt < MAX_UNITS ? options[find_cnt] : 0;
+
+ if (pci_enable_device(pdev))
+ return -EIO;
+
ioaddr = pci_resource_start(pdev, pcibar);
iosize = pci_resource_len(pdev, pcibar);

- if (pci_enable_device(pdev))
- return -EIO;
if (natsemi_pci_info[chip_idx].flags & PCI_USES_MASTER)
pci_set_master(pdev);



2001-02-07 19:30:23

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] natsemi pci_enable_device fixup.

[email protected] wrote:
>
> And they keep on coming.

If you are so motivated, not all of them are in drivers/net (though I
-certainly- appreciate the work you are doing here, too)

Jeff


--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie

2001-02-07 19:35:23

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] natsemi pci_enable_device fixup.


Jeff Garzik wrote...

> If you are so motivated, not all of them are in drivers/net (though I
> -certainly- appreciate the work you are doing here, too)

*nod*, I'll move on to another dir after I've finished net/
I just felt in the mood to remove some of the simpler items that
have been on my TODO for a while.

regards,

Dave.

--
| Dave Jones. http://www.suse.de/~davej
| SuSE Labs