2001-03-26 07:39:01

by Jeff Garzik

[permalink] [raw]
Subject: Re: CML1 cleanup patch

"Eric S. Raymond" wrote:
> Jeff Garzik <[email protected]>:
> > You updated Linux-Mandrake's kernel RPM and Linux-Mandrake's installer?
> > Cool!

> No, I didn't. But I can't even imagine how these changes could break those.

Our kernel build process has to look at CONFIG_xxx because we build
multiple kernels from the same base .config.


> > Please post a patch with only these 19 changes, and make sure to CC it
> > to linux-kernel.

> I don't think this is your decision to make, is it?

I have no control over what you choose to do. It's a free 'net, and you
are free to ignore any and all suggestions.

The normal way to get patches into the kernel is to split them up. I
just sent Linus 21 patches, which got condensed into

> -pre8:
> [...]
> - Jeff Garzik: network driver updates, i810 rng driver, and
> "alloc_etherdev()" network driver insert race condition fix.

Separate out your changes. Make the maintainers aware of your changes.
ie. if it modifies my driver's CONFIG_xxx usage or my subsystem's
Config.in, let me know. ("me" == any maintainer)

Read Documentation/SubmittingPatches.

Jeff


--
Jeff Garzik | May you have warm words on a cold evening,
Building 1024 | a full moon on a dark night,
MandrakeSoft | and a smooth road all the way to your door.