2004-10-19 06:01:48

by Borislav Deianov

[permalink] [raw]
Subject: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops

Hi,

This is a Linux ACPI driver for the IBM ThinkPad laptops. It aims to
support various features of these laptops which are accessible through
the ACPI framework but not otherwise supported by the generic Linux
ACPI drivers.

For more information, see http://ibm-acpi.sf.net/

The attached patch is against 2.6.9-rc4-mm1.

Boris


Attachments:
(No filename) (331.00 B)
ibm-acpi-0.6.patch (47.99 kB)
Download all attachments

2004-10-19 23:57:03

by Brown, Len

[permalink] [raw]
Subject: Re: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops

Applied.

thanks,
-Len

On Tue, 2004-10-19 at 01:59, Borislav Deianov wrote:
> Hi,
>
> This is a Linux ACPI driver for the IBM ThinkPad laptops. It aims to
> support various features of these laptops which are accessible through
> the ACPI framework but not otherwise supported by the generic Linux
> ACPI drivers.
>
> For more information, see http://ibm-acpi.sf.net/
>
> The attached patch is against 2.6.9-rc4-mm1.
>
> Boris
>
>

2004-10-20 00:12:21

by Brown, Len

[permalink] [raw]
Subject: Re: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops

Applied.

thanks,
-Len

On Tue, 2004-10-19 at 01:59, Borislav Deianov wrote:
> Hi,
>
> This is a Linux ACPI driver for the IBM ThinkPad laptops. It aims to
> support various features of these laptops which are accessible through
> the ACPI framework but not otherwise supported by the generic Linux
> ACPI drivers.
>
> For more information, see http://ibm-acpi.sf.net/
>
> The attached patch is against 2.6.9-rc4-mm1.
>
> Boris
>
>

2004-10-20 03:22:23

by Luming Yu

[permalink] [raw]
Subject: RE: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops


Too many hard-code . :-(

I'm working on a generic hotkey driver, which will move configurable
stuff to user space.

Basically, I will standardize hotkey event num dispatched to user space

through /proc/acpi/event. And I will define config and action
interfaces
under /proc/acpi/hotkey to make the hotkey driver has unified interface
to user space daemon. :

ev_config: config interface for event based hotkey.

Format for config event based hotkey:
echo
"config_command:bus_handle:action_handle:internal_event_num:external_hot
key_num" > ev_config
For example:
1. add a new hotkey:
echo "0 : _SB.VGA : _SB.VGA.LCD._BCM :0x86 : 0x86" >
/proc/acpi/ev_config
2. delete a hotkey config:
echo "1: : : :0x86" > /proc/acpi/ev_config
3. update a hotkey config:
echo "0 : _SB.VGA : _SB.VGA.CRT._BCM :0x87 : 0x87" >
/proc/acpi/ev_config

pl_config: config interface for polling based hotkey.
Format for config polling based hotkey:
echo
"config_command:pollin_handle:action_handle:internal_event_num:external_
hotkey_num" > ev_config
For example:
1. add a new hotkey:
echo "0 : _SB.VGA : _SB.POLLING_METHOD : _SB.ACTION_METHOD : 0X86 :
0X86" > /proc/acpi/pl_config
2..

Action: action interface for acpid to call aml method related to the
hotkey event.
Format for calling aml method through action interface.
echo "event_num: argument type : value"
For example:
echo "0x86:1:30" > /proc/acpi/action

Thanks,
Luming

>-----Original Message-----
>From: [email protected]
>[mailto:[email protected]] On Behalf Of
>Borislav Deianov
>Sent: Tuesday, October 19, 2004 2:00 PM
>To: Brown, Len; [email protected];
>[email protected]
>Subject: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops
>
>Hi,
>
>This is a Linux ACPI driver for the IBM ThinkPad laptops. It aims to
>support various features of these laptops which are accessible through
>the ACPI framework but not otherwise supported by the generic Linux
>ACPI drivers.
>
>For more information, see http://ibm-acpi.sf.net/
>
>The attached patch is against 2.6.9-rc4-mm1.
>
>Boris
>

2004-10-21 02:46:23

by Borislav Deianov

[permalink] [raw]
Subject: Re: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops

On Wed, Oct 20, 2004 at 11:18:08AM +0800, Yu, Luming wrote:
>
> I'm working on a generic hotkey driver, which will move configurable
> stuff to user space.
[snip]
> 1. add a new hotkey:
> echo "0 : _SB.VGA : _SB.VGA.LCD._BCM :0x86 : 0x86" >
> /proc/acpi/ev_config

How would user space know what devices and methods to use? In the
kernel, you can use HIDs where available, or check for specific
objects with acpi_get_handle(). Are you going to expose these to user
space somehow?

Boris

2004-10-21 09:11:15

by Luming Yu

[permalink] [raw]
Subject: RE: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops

>
>On Wed, Oct 20, 2004 at 11:18:08AM +0800, Yu, Luming wrote:
>>
>> I'm working on a generic hotkey driver, which will move configurable
>> stuff to user space.
>[snip]
>> 1. add a new hotkey:
>> echo "0 : _SB.VGA : _SB.VGA.LCD._BCM :0x86 : 0x86" >
>> /proc/acpi/ev_config
>
>How would user space know what devices and methods to use? In the
>kernel, you can use HIDs where available, or check for specific
>objects with acpi_get_handle(). Are you going to expose these to user
>space somehow?
>
>Boris
>

Wrt hotkey, there don't have any standard or well known method to
find out which acpi device and acpi methods are for which hotkey.
But, they are working in the similar way, which is achieving hotkey
function through acpi generic core.

So, at the first stage , I have to rely on user or vendor to supply
meaningful data, till we have standard auto-config method.

Thanks,
Luming

2004-10-21 14:01:29

by Erik Rigtorp

[permalink] [raw]
Subject: Re: [PATCH] ibm-acpi-0.6 - ACPI driver for IBM ThinkPad laptops

+ * 2004-10-19 0.6 use acpi_bus_register_driver() to claim HKEY device

I see you implemented my suggestion. Code looks fine now, nice work!

--
Erik Rigtorp <[email protected]>