2001-10-12 12:58:23

by Steve Martin

Subject: PROBLEM: IEEE1284 parport code won't build in 2.4.12

This has already been passed on to Tim Waugh, but here's
a heads-up:

drivers/parport/ieee1284_ops.c -- invokes an undefined
enum entry from parport.h -- as a result the code
won't build.

2001-10-12 13:18:26

by Jesper Juhl

Subject: Re: PROBLEM: IEEE1284 parport code won't build in 2.4.12

Steve Martin wrote:

> This has already been passed on to Tim Waugh, but here's
> a heads-up:
>
> drivers/parport/ieee1284_ops.c -- invokes an undefined
> enum entry from parport.h -- as a result the code
> won't build.


I believe that is the problem that Linus posted this fix for (try it out):

--- linux/drivers/parport/ieee1284_ops.c.origThu Oct 11 09:40:39 2001
+++ linux/drivers/parport/ieee1284_ops.cThu Oct 11 09:40:42 2001
@@ -362,7 +362,7 @@
} else {
DPRINTK (KERN_DEBUG "%s: ECP direction: failed to reverse\n",
port->name);
-port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
} return retval;
@@ -394,7 +394,7 @@
DPRINTK (KERN_DEBUG
"%s: ECP direction: failed to switch forward\n",
port->name);
-port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
}



Regards,
Jesper Juhl