2001-12-02 18:17:52

by Andreas Haumer

[permalink] [raw]
Subject: [PATCH] missing gendisk initialization in cpqarray.c (Linux-2.2.20)

Hi!

The following patch adds code to initialize gendisk.fops
in cpqarray.c. It's needed to avoid a kernel warning message
when using devfs with the Compaq RAID Controller.

--- linux-2.2.20/drivers/block/cpqarray.c Fri Nov 2 17:39:06
2001
+++ linux/drivers/block/cpqarray.c Sun Dec 2 19:05:11 2001
@@ -513,6 +513,7 @@
ida_gendisk[i].init = ida_geninit;
ida_gendisk[i].part = ida + (i*256);
ida_gendisk[i].sizes = ida_sizes + (i*256);
+ ida_gendisk[i].fops = &ida_fops;
/* ida_gendisk[i].nr_real is handled by getgeometry */

blk_dev[MAJOR_NR+i].request_fn = request_fns[i];


HTH

- andreas

--
Andreas Haumer | mailto:[email protected]
*x Software + Systeme | http://www.xss.co.at/
Karmarschgasse 51/2/20 | Tel: +43-1-6060114-0
A-1100 Vienna, Austria | Fax: +43-1-6060114-71


2001-12-02 18:52:29

by Alan

[permalink] [raw]
Subject: Re: [PATCH] missing gendisk initialization in cpqarray.c (Linux-2.2.20)

> The following patch adds code to initialize gendisk.fops
> in cpqarray.c. It's needed to avoid a kernel warning message
> when using devfs with the Compaq RAID Controller.
>
> --- linux-2.2.20/drivers/block/cpqarray.c Fri Nov 2 17:39:06
> 2001

Im confused. Linux 2.2 doesn't include devfs. This patch therefore seems
nonsense

2001-12-02 19:12:29

by Andreas Haumer

[permalink] [raw]
Subject: Re: [PATCH] missing gendisk initialization in cpqarray.c (Linux-2.2.20)

Alan Cox wrote:
>
> > The following patch adds code to initialize gendisk.fops
> > in cpqarray.c. It's needed to avoid a kernel warning message
> > when using devfs with the Compaq RAID Controller.
> >
> > --- linux-2.2.20/drivers/block/cpqarray.c Fri Nov 2 17:39:06
> > 2001
>
> Im confused. Linux 2.2 doesn't include devfs. This patch therefore seems
> nonsense

Hm, ok...

Then this patch (and the one for cciss.c) should better
go to Richard for inclusion in the 2.2.20 devfs patch?

Regards,

- andreas

--
Andreas Haumer | mailto:[email protected]
*x Software + Systeme | http://www.xss.co.at/
Karmarschgasse 51/2/20 | Tel: +43-1-6060114-0
A-1100 Vienna, Austria | Fax: +43-1-6060114-71