2002-02-14 01:53:31

by Frank Jacobberger

Subject: 2.5.5-pre1 and rd.c

Trying a make bzImage netted this nice little problem:
------------------------------------------------------------------------------------------------------------------------------
gcc -D__KERNEL__ -I/usr/src/linux-2.5.4/include -Wall -Wstrict-prototypes
-Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
-pipe
-mpreferred-stack-boundary=2 -march=i686 -DKBUILD_BASENAME=rd -c -o
rd.o rd.c
rd.c: In function `rd_make_request':
rd.c:271: too many arguments to function
make[3]: *** [rd.o] Error 1
make[3]: Leaving directory `/usr/src/linux-2.5.4/drivers/block'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linux-2.5.4/drivers/block'
make[1]: *** [_subdir_block] Error 2
make[1]: Leaving directory `/usr/src/linux-2.5.4/drivers'
make: *** [_dir_drivers] Error 2

Any ideas?

Thanks,

Frank

2002-02-14 02:26:27

by Jeff Garzik

Subject: Re: 2.5.5-pre1 and rd.c

Frank Jacobberger wrote:
>
> Trying a make bzImage netted this nice little problem:
> ------------------------------------------------------------------------------------------------------------------------------
> gcc -D__KERNEL__ -I/usr/src/linux-2.5.4/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe
> -mpreferred-stack-boundary=2 -march=i686 -DKBUILD_BASENAME=rd -c -o
> rd.o rd.c
> rd.c: In function `rd_make_request':
> rd.c:271: too many arguments to function

I would have sworn I merged that with axboe.

Delete the second argument to the function, that should fix it.

--
Jeff Garzik | "I went through my candy like hot oatmeal
Building 1024 | through an internally-buttered weasel."
MandrakeSoft | - goats.com

2002-02-14 07:35:49

by Jens Axboe

Subject: Re: 2.5.5-pre1 and rd.c

On Wed, Feb 13 2002, Jeff Garzik wrote:
> Frank Jacobberger wrote:
> >
> > Trying a make bzImage netted this nice little problem:
> > ------------------------------------------------------------------------------------------------------------------------------
> > gcc -D__KERNEL__ -I/usr/src/linux-2.5.4/include -Wall -Wstrict-prototypes
> > -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> > -pipe
> > -mpreferred-stack-boundary=2 -march=i686 -DKBUILD_BASENAME=rd -c -o
> > rd.o rd.c
> > rd.c: In function `rd_make_request':
> > rd.c:271: too many arguments to function
>
> I would have sworn I merged that with axboe.

You did, apparently Linus never did the pull on that one. I'll make sure
it gets pushed again :)

--
Jens Axboe