2002-02-20 02:50:28

by Cesar Suga

[permalink] [raw]
Subject: A simple patch for SIS (documentation and kbuild)

Hello, all.

As I've spoken with Alan Cox and Christoph Pittracher, there's a
problem with the dependency. I do not know who takes care of the
documentation stuff and kbuild procedures, but here they are.

(okay. Building FB_SIS as module and DRM_SIS as builtin completely
*breaks* dependencies, so I did this to enforce them both as modules or
both as builtin)

The patch is very simple, adds the Config.in 'if' and the
CONFIG_DRM_SIS description in Documentation/Configure.help.

Thanks,
Cesar Suga <[email protected]>



Attachments:
sis-patch-2.4.18-rc2-ac1.diff (1.10 kB)

2002-02-20 18:34:02

by Thomas Winischhofer

[permalink] [raw]
Subject: Re: A simple patch for SIS (documentation and kbuild)

Jean Paul Sartre wrote:

+SiS 300/540/630
+CONFIG_DRM_SIS
+ Choose this option if you have a SIS 300, 540 or 630 graphics card.
+ If M is selected, the module will be called sis.o. AGP support is
+ required for this driver to work.

Before posting patches you'd better inform yourself.

AGP is *not* required.

Thomas

--
Thomas Winischhofer
Vienna/Austria
mailto:[email protected] *** http://www.webit.com/tw

2002-02-20 19:28:57

by Cesar Suga

[permalink] [raw]
Subject: Re: A simple patch for SIS (documentation and kbuild)

On Wed, 20 Feb 2002, Thomas Winischhofer wrote:

> +SiS 300/540/630
> +CONFIG_DRM_SIS
> + Choose this option if you have a SIS 300, 540 or 630 graphics card.
> + If M is selected, the module will be called sis.o. AGP support is
> + required for this driver to work.

> Before posting patches you'd better inform yourself.

> AGP is *not* required.

Ah, sorry. I didn't notice __MUST_HAVE_AGP to be zero. I'll take
care.

Regards,
Cesar Suga <[email protected]>


2002-02-20 21:04:17

by Thomas Winischhofer

[permalink] [raw]
Subject: Re: A simple patch for SIS (documentation and kbuild)

Cesar Suga wrote:
>
> On Wed, 20 Feb 2002, Thomas Winischhofer wrote:
>
> > +SiS 300/540/630
> > +CONFIG_DRM_SIS
> > + Choose this option if you have a SIS 300, 540 or 630 graphics card.
> > + If M is selected, the module will be called sis.o. AGP support is
> > + required for this driver to work.
>
> > Before posting patches you'd better inform yourself.
>
> > AGP is *not* required.
>
> Ah, sorry. I didn't notice __MUST_HAVE_AGP to be zero. I'll take
> care.

I'd recommend the following dependencies:

Rule 1:
If SiS DRM is selected, SiS framebuffer *MUST* be selected as well

Rule 2:
If SiS framebuffer is a MODULE, SiS DRM *MUST* be a MODULE, too

Rule 3:
If SiS DRM is compiled into the kernel (which I don't recommend), sisfb
*MUST* be compiled into the kernel, too.

(SiS framebuffer can be inside the kernel, in this case DRM can be a
module)

Thomas


--
Thomas Winischhofer
Vienna/Austria
mailto:[email protected] *** http://www.webit.com/tw