2002-03-16 04:10:29

by Dan Kegel

[permalink] [raw]
Subject: Re: libc/1427: gprof does not profile threads

> On Fri Mar 15, 2002 at 04:19:17PM -0800, Ulrich Drepper wrote:
> > On Fri, 2002-03-15 at 13:56, Dan Kegel wrote:
> > > Ulrich, do you at least agree that it would be desirable for
> > > gprof to work properly on multithreaded programs?
> >
> > No. gprof is uselss in today world.
>
> Then why not change sysdeps/generic/initfini.c with something like:
>
> - if (gmon_start)
> + if (gmon_start && __pthread_initialize_minimal)
> gmon_start ();
>
> So it doesn't even try when threading?

I believe Ulrich's proposed fix would be

> - if (gmon_start)
> + if (gmon_start && 0)
> gmon_start ();

as he did not distinguish between threaded and nonthreaded programs
when he said gprof was useless.

- Dan