2002-04-16 17:13:12

by Richard Gooch

[permalink] [raw]
Subject: OK, who broke the serial driver in 2.4.19-pre7?

Hi, all. 2.4.19-pre7 has broken the serial driver. With 2.4.19-pre6
and before, my first serial port was ttyS0 (4, 64), and I got these
kernel messages:
ttyS00 at 0x03f8 (irq = 4) is a 16550A
ttyS01 at 0x02f8 (irq = 3) is a 16550A

With 2.4.19-pre7, my first serial port is ttyS1 (4, 65), and I get:
ttyS01 at 0x03f8 (irq = 4) is a 16550A
ttyS02 at 0x02f8 (irq = 3) is a 16550A

Was this broken by the HCDP serial ports changes?

Regards,

Richard....
Permanent: [email protected]
Current: [email protected]


2002-04-16 17:39:30

by Alan

[permalink] [raw]
Subject: Re: OK, who broke the serial driver in 2.4.19-pre7?

> Hi, all. 2.4.19-pre7 has broken the serial driver. With 2.4.19-pre6
> and before, my first serial port was ttyS0 (4, 64), and I got these
> kernel messages:
> Was this broken by the HCDP serial ports changes?

Yes. Someone put the HCDP below not above the basic x86 ports. Tweak
include/asm-i386/serial.h and that should be well.

Alan

2002-04-16 18:09:24

by Khalid Aziz

[permalink] [raw]
Subject: Re: OK, who broke the serial driver in 2.4.19-pre7?

Alan Cox wrote:
>
> > Hi, all. 2.4.19-pre7 has broken the serial driver. With 2.4.19-pre6
> > and before, my first serial port was ttyS0 (4, 64), and I got these
> > kernel messages:
> > Was this broken by the HCDP serial ports changes?
>
> Yes. Someone put the HCDP below not above the basic x86 ports. Tweak
> include/asm-i386/serial.h and that should be well.
>
> Alan
>

Sorry, that was my fault. Here is a patch to fix it.

--
Khalid


--- linux-2.4.18-hcdpold/include/asm-i386/serial.h Tue Apr 16
12:05:27 2002
+++ linux-2.4.18-hcdp/include/asm-i386/serial.h Tue Apr 16 12:02:54 2002
@@ -140,8 +140,8 @@
#endif

#define SERIAL_PORT_DFNS \
- HCDP_SERIAL_PORT_DEFNS \
STD_SERIAL_PORT_DEFNS \
+ HCDP_SERIAL_PORT_DEFNS \
EXTRA_SERIAL_PORT_DEFNS \
HUB6_SERIAL_PORT_DFNS \
MCA_SERIAL_PORT_DFNS


====================================================================
Khalid Aziz Linux Systems Operation R&D
(970)898-9214 Hewlett-Packard
[email protected] Fort Collins, CO