2017-10-31 18:18:49

by Madhani, Himanshu

[permalink] [raw]
Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Bart,

> On Oct 31, 2017, at 11:12 AM, Bart Van Assche <[email protected]> wrote:
>
> On Tue, 2017-10-31 at 18:03 +0000, Madhani, Himanshu wrote:
>> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <[email protected]> wrote:
>>>> In preparation for unconditionally passing the struct timer_list
>>>> pointer to all timer callbacks, switch to using the new timer_setup()
>>>> and from_timer() to pass the timer pointer explicitly.
>>>
>>> Cavium folks: Please verify!
>>
>> I’ve checked on my setup and i am seeing regression with this patch applied.
>>
>> Driver load locks up the system with this patch applied.
>>
>> NACK
>
> That feedback is not very helpful …
>

Here’s my setup details

4.14.0-rc7 + scsi_misc-4.15 qla2xxx patches from Martin’s tree + current patch.

System has 3 adapters 8G/16G/32G.

> Anyway, what kernel source tree did you use in your testing? I may be able to
> free up some time to look into this myself.
>
> Bart.

Thanks,
- Himanshu