2021-03-23 18:59:25

by Yu Liu

Subject: [PATCH v1] Bluetooth: Return whether a connection is outbound

When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
space we will set the flags to tell if the established connection is
outbound or not. This is useful for the user space to log better metrics
and error messages.

Reviewed-by: Miao-chen Chou <[email protected]>
Reviewed-by: Alain Michaud <[email protected]>

Signed-off-by: Yu Liu <[email protected]>
---

Changes in v1:
- Initial change

include/net/bluetooth/mgmt.h | 2 ++
net/bluetooth/mgmt.c | 5 +++++
2 files changed, 7 insertions(+)

diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index a7cffb069565..d66bc6938b58 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -885,6 +885,8 @@ struct mgmt_ev_new_long_term_key {
struct mgmt_ltk_info key;
} __packed;

+#define MGMT_DEV_CONN_DIRECTION_OUT 0x01
+
#define MGMT_EV_DEVICE_CONNECTED 0x000B
struct mgmt_ev_device_connected {
struct mgmt_addr_info addr;
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 90334ac4a135..fc0ff6dc7ebf 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -8772,6 +8772,11 @@ void mgmt_device_connected(struct hci_dev *hdev, struct hci_conn *conn,
bacpy(&ev->addr.bdaddr, &conn->dst);
ev->addr.type = link_to_bdaddr(conn->type, conn->dst_type);

+ if (conn->out)
+ flags |= MGMT_DEV_CONN_DIRECTION_OUT;
+ else
+ flags &= ~MGMT_DEV_CONN_DIRECTION_OUT;
+
ev->flags = __cpu_to_le32(flags);

/* We must ensure that the EIR Data fields are ordered and
--
2.31.0.291.g576ba9dcdaf-goog

2021-03-24 07:23:52

by Marcel Holtmann

Subject: Re: [PATCH v1] Bluetooth: Return whether a connection is outbound

Hi Yu,

> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
> space we will set the flags to tell if the established connection is
> outbound or not. This is useful for the user space to log better metrics
> and error messages.
>
> Reviewed-by: Miao-chen Chou <[email protected]>
> Reviewed-by: Alain Michaud <[email protected]>
>
> Signed-off-by: Yu Liu <[email protected]>
> ---
>
> Changes in v1:
> - Initial change

please send a patch to describe the API change in doc/mgmt-api.txt first.

Regards

Marcel