diff -u -r -U 6 cmp/include/linux/mmzone.h linux-2.5.24/include/linux/mmzone.h
--- cmp/include/linux/mmzone.h Fri Jun 21 04:23:42 2002
+++ linux-2.5.24/include/linux/mmzone.h Thu Jun 27 18:00:25 2002
@@ -88,16 +88,21 @@
* rarely used fields:
*/
char *name;
unsigned long size;
} zone_t;
-#define ZONE_DMA 0
-#define ZONE_NORMAL 1
-#define ZONE_HIGHMEM 2
-#define MAX_NR_ZONES 3
+enum zone_type {
+
+ ZONE_DMA,
+ ZONE_NORMAL,
+ ZONE_HIGHMEM,
+ MAX_NR_ZONES,
+
+};
+
/*
* One allocation request operates on a zonelist. A zonelist
* is a list of zones, the first one is the 'goal' of the
* allocation, the other zones are fallback zones, in decreasing
* priority.
Manik Raina wrote:
> with enums, we dont have to increment MAX_NR_ZONES everytime a new one
s/one/zonetype
> is added .
>
If no one has any objections, Can this be applied as a patch ?
Manik Raina wrote:
>
> is there a particular reason we dislike constructs as attached in the
> diffs below ?
> with enums, we dont have to increment MAX_NR_ZONES everytime a new one
> is added .
>
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> diff -u -r -U 6 cmp/include/linux/mmzone.h linux-2.5.24/include/linux/mmzone.h
> --- cmp/include/linux/mmzone.h Fri Jun 21 04:23:42 2002
> +++ linux-2.5.24/include/linux/mmzone.h Thu Jun 27 18:00:25 2002
> @@ -88,16 +88,21 @@
> * rarely used fields:
> */
> char *name;
> unsigned long size;
> } zone_t;
>
> -#define ZONE_DMA 0
> -#define ZONE_NORMAL 1
> -#define ZONE_HIGHMEM 2
> -#define MAX_NR_ZONES 3
> +enum zone_type {
> +
> + ZONE_DMA,
> + ZONE_NORMAL,
> + ZONE_HIGHMEM,
> + MAX_NR_ZONES,
> +
> +};
> +
>
> /*
> * One allocation request operates on a zonelist. A zonelist
> * is a list of zones, the first one is the 'goal' of the
> * allocation, the other zones are fallback zones, in decreasing
> * priority.